Re: [HACKERS] Kludge in pg_standby.c

2008-06-23 Thread Simon Riggs
On Mon, 2008-06-23 at 17:38 -0400, Bruce Momjian wrote: > Is this fixed and this block of code can be removed? There'll be some action for the next CommitFest. -- Simon Riggs www.2ndQuadrant.com PostgreSQL Training, Services and Support -- Sent via pgsql-hackers mailing list (pg

Re: [HACKERS] Kludge in pg_standby.c

2008-06-23 Thread Bruce Momjian
Alvaro Herrera wrote: > > Gregory Stark wrote: > > > > > > There's a suspicious ifdef in pg_standby for WIN32 which smells like a > > > kludge > > > added to work around a Windows problem which makes it work but at great > > > expense: > > > > > > #ifdef WIN32 > > > /* > > >

Re: [HACKERS] Kludge in pg_standby.c

2008-04-10 Thread Alvaro Herrera
> Gregory Stark wrote: > > > > There's a suspicious ifdef in pg_standby for WIN32 which smells like a > > kludge > > added to work around a Windows problem which makes it work but at great > > expense: > > > > #ifdef WIN32 > > /* > > * Windows reports that the fi

Re: [HACKERS] Kludge in pg_standby.c

2008-04-08 Thread Bruce Momjian
I have moved this to the next commit-fest. --- Gregory Stark wrote: > > There's a suspicious ifdef in pg_standby for WIN32 which smells like a kludge > added to work around a Windows problem which makes it work but at great

Re: [HACKERS] Kludge in pg_standby.c

2008-04-06 Thread Magnus Hagander
; > Sent: 08-04-07, 1:54:37 > Subject: Re: [HACKERS] Kludge in pg_standby.c > > Magnus, have you looked at this yet? > > --- > > Gregory Stark wrote: > > > > There's a suspicious ifdef

Re: [HACKERS] Kludge in pg_standby.c

2008-04-06 Thread Bruce Momjian
Magnus, have you looked at this yet? --- Gregory Stark wrote: > > There's a suspicious ifdef in pg_standby for WIN32 which smells like a kludge > added to work around a Windows problem which makes it work but at great > exp

[HACKERS] Kludge in pg_standby.c

2007-12-03 Thread Gregory Stark
There's a suspicious ifdef in pg_standby for WIN32 which smells like a kludge added to work around a Windows problem which makes it work but at great expense: #ifdef WIN32 /* * Windows reports that the file has the right number of bytes * even tho