Re: [HACKERS] Materialized View patch broke pg_dump

2013-03-13 Thread Kevin Grittner
Andrew Dunstan and...@dunslane.net wrote: On 03/11/2013 12:30 PM, Fujii Masao wrote: Andrew Dunstan and...@dunslane.net wrote: On 03/11/2013 10:43 AM, Andrew Dunstan wrote: I noticed this morning that I am still getting failures on 9.0, 9.1 and 9.2 which cause my cross-version upgrade

Re: [HACKERS] Materialized View patch broke pg_dump

2013-03-13 Thread Kevin Grittner
Kevin Grittner kgri...@ymail.com wrote: Andrew Dunstan and...@dunslane.net wrote: On 03/11/2013 12:30 PM, Fujii Masao wrote: Andrew Dunstan and...@dunslane.net wrote: The problem is that pg_dump is sending an empty query in versions less than 9.3, and choking on that. Suggested fix attached

Re: [HACKERS] Materialized View patch broke pg_dump

2013-03-11 Thread Andrew Dunstan
On 03/06/2013 10:55 AM, Kevin Grittner wrote: Bernd Helmle maili...@oopsware.de wrote: Looking into this issue, it seems the version check in getTables() of pg_dump.c is wrong. Shouldn't the check be if (fout-remoteVersion = 90300) { } since this is where pg_relation_is_scannable() is

Re: [HACKERS] Materialized View patch broke pg_dump

2013-03-11 Thread Andrew Dunstan
On 03/11/2013 10:43 AM, Andrew Dunstan wrote: On 03/06/2013 10:55 AM, Kevin Grittner wrote: Bernd Helmle maili...@oopsware.de wrote: Looking into this issue, it seems the version check in getTables() of pg_dump.c is wrong. Shouldn't the check be if (fout-remoteVersion = 90300) { } since

Re: [HACKERS] Materialized View patch broke pg_dump

2013-03-11 Thread Fujii Masao
On Tue, Mar 12, 2013 at 12:43 AM, Andrew Dunstan and...@dunslane.net wrote: On 03/11/2013 10:43 AM, Andrew Dunstan wrote: On 03/06/2013 10:55 AM, Kevin Grittner wrote: Bernd Helmle maili...@oopsware.de wrote: Looking into this issue, it seems the version check in getTables() of pg_dump.c

Re: [HACKERS] Materialized View patch broke pg_dump

2013-03-11 Thread Andrew Dunstan
On 03/11/2013 12:30 PM, Fujii Masao wrote: On Tue, Mar 12, 2013 at 12:43 AM, Andrew Dunstan and...@dunslane.net wrote: On 03/11/2013 10:43 AM, Andrew Dunstan wrote: On 03/06/2013 10:55 AM, Kevin Grittner wrote: Bernd Helmle maili...@oopsware.de wrote: Looking into this issue, it seems the

[HACKERS] Materialized View patch broke pg_dump

2013-03-06 Thread Bernd Helmle
It looks like the recent matview patch broke pg_dump in a way, which make it impossible to dump 9.1 and 9.2 databases. it fails with pg_dump: [Archivierer (DB)] query failed: ERROR: function pg_relation_is_scannable(oid) does not exist Looking into this issue, it seems the version check in

Re: [HACKERS] Materialized View patch broke pg_dump

2013-03-06 Thread Kevin Grittner
Bernd Helmle maili...@oopsware.de wrote: It looks like the recent matview patch broke pg_dump in a way, which make it impossible to dump 9.1 and 9.2 databases. it fails with pg_dump: [Archivierer (DB)] query failed: ERROR:  function pg_relation_is_scannable(oid) does not exist Looking

Re: [HACKERS] Materialized View patch broke pg_dump

2013-03-06 Thread Kevin Grittner
Bernd Helmle maili...@oopsware.de wrote: Looking into this issue, it seems the version check in getTables() of pg_dump.c is wrong. Shouldn't the check be if (fout-remoteVersion = 90300) { } since this is where pg_relation_is_scannable() is introduced? Fixed. Thanks for the report!