On Mon, Jan 25, 2010 at 11:09:12AM -0500, Andrew Dunstan wrote:
>
> Tim Bunce wrote:
> >
> >FYI I've an updated patch ready but I'll wait till the commitfest has
> >got 'closer' as there's a fair chance a further update will be needed
> >anyway to make a patch that applies cleanly.
>
> I want to
Tim Bunce wrote:
FYI I've an updated patch ready but I'll wait till the commitfest has
got 'closer' as there's a fair chance a further update will be needed
anyway to make a patch that applies cleanly.
I want to deal with this today or tomorrow, so don't sit on it, please.
cheers
andr
On Sat, Jan 23, 2010 at 06:40:03PM -0700, Alex Hunsaker wrote:
> On Sat, Jan 23, 2010 at 16:16, Tim Bunce wrote:
> > On Fri, Jan 22, 2010 at 08:59:10PM -0700, Alex Hunsaker wrote:
> >> On Thu, Jan 14, 2010 at 09:07, Tim Bunce wrote:
> >> I'd vote for use warnings; as well.
> >
> > I would to, but
On Sat, Jan 23, 2010 at 16:16, Tim Bunce wrote:
> On Fri, Jan 22, 2010 at 08:59:10PM -0700, Alex Hunsaker wrote:
>> On Thu, Jan 14, 2010 at 09:07, Tim Bunce wrote:
>> I'd vote for use warnings; as well.
>
> I would to, but sadly it's not that simple.
>
> warnings uses Carp and Carp uses eval { ..
On Sat, Jan 23, 2010 at 16:26, Andrew Dunstan wrote:
>
>
> Tim Bunce wrote:
>>>
>>> - } keys %$imports;
>>> + } sort keys %$imports;
>>>
>>
>> Ok, good.
>>
>>
>>>
>>> - my $funcsrc;
>>> - $funcsrc .= qq[ undef *{'$name'}; *{'$name'} = sub { $BEGIN $prolog
>>> $src } ];
>>> - #warn "plper
Tim Bunce wrote:
- } keys %$imports;
+ } sort keys %$imports;
Ok, good.
- my $funcsrc;
- $funcsrc .= qq[ undef *{'$name'}; *{'$name'} = sub { $BEGIN $prolog $src }
];
- #warn "plperl mkfuncsrc: $funcsrc\n";
- return $funcsrc;
+ return qq[ undef *{'$name'}; *{'$name'}
On Fri, Jan 22, 2010 at 08:59:10PM -0700, Alex Hunsaker wrote:
> On Thu, Jan 14, 2010 at 09:07, Tim Bunce wrote:
> > - Allow (ineffective) use of 'require' in plperl
> > If the required module is not already loaded then it dies.
> > So "use strict;" now works in plperl.
>
> [ BTW I think th
On Sat, Jan 23, 2010 at 12:42, David E. Wheeler wrote:
> On Jan 23, 2010, at 11:20 AM, Alex Hunsaker wrote:
>
>> Well no, i suppose we could fix that via:
>> $name =~ s/[:|']/_/g;
>>
>> Im betting that was the intent.
>
> Doubtful. In Perl, the package separator is either `::` or `'` (for
> hyste
On Jan 23, 2010, at 11:20 AM, Alex Hunsaker wrote:
> Well no, i suppose we could fix that via:
> $name =~ s/[:|']/_/g;
>
> Im betting that was the intent.
Doubtful. In Perl, the package separator is either `::` or `'` (for hysterical
reasons). So the original code was replacing any package sepa
On Sat, Jan 23, 2010 at 11:30, David E. Wheeler wrote:
> On Jan 22, 2010, at 7:59 PM, Alex Hunsaker wrote:
>
>> $name =~ s/::|'/_/g; # avoid package delimiters
>> + $name =~ s/'/\'/g;
>
> Looks to me like ' is already handled in the line above the one you added, no?
Well no, i suppose we cou
On Jan 22, 2010, at 7:59 PM, Alex Hunsaker wrote:
>$name =~ s/::|'/_/g; # avoid package delimiters
> + $name =~ s/'/\'/g;
Looks to me like ' is already handled in the line above the one you added, no?
David
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make chan
On Thu, Jan 14, 2010 at 09:07, Tim Bunce wrote:
> - Allow (ineffective) use of 'require' in plperl
> If the required module is not already loaded then it dies.
> So "use strict;" now works in plperl.
[ BTW I think this is awesome! ]
Id vote for use warnings; as well.
> - Stored procedure
On Thu, Jan 14, 2010 at 05:49:54PM +, Tim Bunce wrote:
> On Thu, Jan 14, 2010 at 09:34:42AM -0800, David E. Wheeler wrote:
> > On Jan 14, 2010, at 8:07 AM, Tim Bunce wrote:
> >
> > > - Stored procedure subs are now given names.
> > >The names are not visible in ordinary use, but they make
On Thu, Jan 14, 2010 at 09:34:42AM -0800, David E. Wheeler wrote:
> On Jan 14, 2010, at 8:07 AM, Tim Bunce wrote:
>
> > - Stored procedure subs are now given names.
> >The names are not visible in ordinary use, but they make
> >tools like Devel::NYTProf and Devel::Cover _much_ more useful.
On Jan 14, 2010, at 8:07 AM, Tim Bunce wrote:
> - Stored procedure subs are now given names.
>The names are not visible in ordinary use, but they make
>tools like Devel::NYTProf and Devel::Cover _much_ more useful.
Wasn't this in the previous patch, too?
Best,
David
--
Sent via pgsql-
This is the second of the patches to be split out from the former
'plperl feature patch 1'.
Changes in this patch:
- Allow (ineffective) use of 'require' in plperl
If the required module is not already loaded then it dies.
So "use strict;" now works in plperl.
- Pre-load the feature modu
16 matches
Mail list logo
