Re: [HACKERS] Misdesigned command/status APIs for parallel dump/restore

2016-09-27 Thread Kevin Grittner
This patch also applied with minor offsets, compiled without warning, and passes regression tests, including `make check-world` with TAP tests enabled. It looks good to me, presenting a cleaner API. I really want to get this to the point where we can dump and restore nested materialized views

Re: [HACKERS] Misdesigned command/status APIs for parallel dump/restore

2016-06-02 Thread Tom Lane
I wrote: > In the attached patch for this, I took a middle ground of separating out > the command and status string building and parsing functions. There isn't > presently any provision for letting archive format modules override these, > but that could easily be added if we ever need it.

Re: [HACKERS] Misdesigned command/status APIs for parallel dump/restore

2016-06-01 Thread Tom Lane
I wrote: > I am pretty strongly tempted to get rid of MasterStartParallelItem > altogether and just hard-code what it does in DispatchJobForTocEntry. > ... > A different line of thought would be to fix the worker-command-parsing > situation by allowing the parsing to happen in format-specific

[HACKERS] Misdesigned command/status APIs for parallel dump/restore

2016-05-28 Thread Tom Lane
pg_dump's APIs for parallel dump/restore include an archive-format-specific MasterStartParallelItem function, which is evidently intended to allow format-specific data to be sent to the worker process during startup of a parallel sub-job. However, no such data can be sent in practice, because