Re: [HACKERS] Missing conversion error handling in postgres_fdw

2016-03-15 Thread Etsuro Fujita
On 2016/03/16 5:55, Robert Haas wrote: On Tue, Mar 15, 2016 at 4:06 AM, Etsuro Fujita wrote: Attached is a patch for that. Hmm, I'd say you are right. Committed. Thank you for taking care of this! Best regards, Etsuro Fujita -- Sent via pgsql-hackers

Re: [HACKERS] Missing conversion error handling in postgres_fdw

2016-03-15 Thread Robert Haas
On Tue, Mar 15, 2016 at 4:06 AM, Etsuro Fujita wrote: > I noticed that this in make_tuple_from_result_row does conversion error > handling only for the ordinary-column case (ie, errpos.cur_attno is set > for that case, but not for the ctid case). > > /*

[HACKERS] Missing conversion error handling in postgres_fdw

2016-03-15 Thread Etsuro Fujita
Hi, I noticed that this in make_tuple_from_result_row does conversion error handling only for the ordinary-column case (ie, errpos.cur_attno is set for that case, but not for the ctid case). /* convert value to internal representation */ if (i > 0) { /*