Re: [HACKERS] Missing newlines in verbose logs of pg_dump, introduced by RLS patch

2014-10-03 Thread Stephen Frost
* Stephen Frost (sfr...@snowman.net) wrote: * Michael Paquier (michael.paqu...@gmail.com) wrote: On Mon, Sep 29, 2014 at 10:07 AM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: The schema name is missing... attached patch add it. Ah, right, thanks. It didn't occur to me

Re: [HACKERS] Missing newlines in verbose logs of pg_dump, introduced by RLS patch

2014-09-29 Thread Stephen Frost
* Michael Paquier (michael.paqu...@gmail.com) wrote: On Mon, Sep 29, 2014 at 10:07 AM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: The schema name is missing... attached patch add it. Ah, right, thanks. It didn't occur to me immediately :) Your patch looks good to me, and you

Re: [HACKERS] Missing newlines in verbose logs of pg_dump, introduced by RLS patch

2014-09-28 Thread Fabrízio de Royes Mello
On Sun, Sep 28, 2014 at 1:36 AM, Michael Paquier michael.paqu...@gmail.com wrote: Hi all, Recent commit 491c029 introducing RLS has broken a bit the verbose logs of pg_dump, one message missing a newline: + if (g_verbose) + write_msg(NULL, reading

Re: [HACKERS] Missing newlines in verbose logs of pg_dump, introduced by RLS patch

2014-09-28 Thread Michael Paquier
On Mon, Sep 29, 2014 at 10:07 AM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: The schema name is missing... attached patch add it. Ah, right, thanks. It didn't occur to me immediately :) Your patch looks good to me, and you are updating as well the second message that missed the

[HACKERS] Missing newlines in verbose logs of pg_dump, introduced by RLS patch

2014-09-27 Thread Michael Paquier
Hi all, Recent commit 491c029 introducing RLS has broken a bit the verbose logs of pg_dump, one message missing a newline: + if (g_verbose) + write_msg(NULL, reading row-security enabled for table \%s\, +