Re: [HACKERS] Modest proposal: run check_keywords.pl on every build

2012-09-27 Thread Robert Haas
On Wed, Sep 26, 2012 at 9:16 PM, Tom Lane t...@sss.pgh.pa.us wrote: Any objections? None, and my apologies for the oversight. I would really like to have a cross-check for duplicated OIDs, too. After a couple of years I think I have learned most of the rules for what stuff I need to cross-check

[HACKERS] Modest proposal: run check_keywords.pl on every build

2012-09-26 Thread Tom Lane
I've had it with mopping up after oversights like this one: http://archives.postgresql.org/pgsql-hackers/2012-09/msg01057.php We made a script (src/tools/check_keywords.pl) to check for this type of error years ago, and even added it to the top-level maintainer-check target awhile back, but

Re: [HACKERS] Modest proposal: run check_keywords.pl on every build

2012-09-26 Thread Andrew Dunstan
On 09/26/2012 09:16 PM, Tom Lane wrote: I've had it with mopping up after oversights like this one: http://archives.postgresql.org/pgsql-hackers/2012-09/msg01057.php We made a script (src/tools/check_keywords.pl) to check for this type of error years ago, and even added it to the top-level