Re: [HACKERS] Moving of INT64_FORMAT to c.h

2014-10-22 Thread Steve Singer
On 10/22/2014 04:17 PM, Robert Haas wrote: Slonik used to include postgre_fe.h but back in 2011 or so we stopped doing so because it was causing issues (I think on win32 builds) That seems like something we ought to consider fixing, but obviously we'd need more details. When I'll try to find

Re: [HACKERS] Moving of INT64_FORMAT to c.h

2014-10-22 Thread Tom Lane
Robert Haas writes: > On Wed, Oct 22, 2014 at 4:12 PM, Steve Singer wrote: >> So the header of c.h says "Note that the definitions here are not intended >> to be exposed to clients" >> but >> postgres_fe.h says "This should be the first file included by PostgreSQL >> client libraries and" >> >>

Re: [HACKERS] Moving of INT64_FORMAT to c.h

2014-10-22 Thread Robert Haas
On Wed, Oct 22, 2014 at 4:12 PM, Steve Singer wrote: > So the header of c.h says "Note that the definitions here are not intended > to be exposed to clients" > but > postgres_fe.h says "This should be the first file included by PostgreSQL > client libraries and" > > Should client programs that liv

Re: [HACKERS] Moving of INT64_FORMAT to c.h

2014-10-22 Thread Steve Singer
On 10/16/2014 08:08 AM, Andres Freund wrote: On 2014-10-16 08:04:17 -0400, Jan Wieck wrote: Hi, PostgreSQL has for ages defined INT64_FORMAT and UINT64_FORMAT in pg_config.h. This commit http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=ce486056ecd28050 moved those definitions to

Re: [HACKERS] Moving of INT64_FORMAT to c.h

2014-10-16 Thread Andres Freund
On 2014-10-16 08:04:17 -0400, Jan Wieck wrote: > Hi, > > PostgreSQL has for ages defined INT64_FORMAT and UINT64_FORMAT in > pg_config.h. This commit > > http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=ce486056ecd28050 > > moved those definitions to c.h, which breaks compilation of

[HACKERS] Moving of INT64_FORMAT to c.h

2014-10-16 Thread Jan Wieck
Hi, PostgreSQL has for ages defined INT64_FORMAT and UINT64_FORMAT in pg_config.h. This commit http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=ce486056ecd28050 moved those definitions to c.h, which breaks compilation of all released Slony-I versions against current master. Can