Re: [HACKERS] NOT NULL constraints on range partition key columns

2017-05-18 Thread Amit Langote
On 2017/05/19 3:06, Robert Haas wrote: > On Tue, May 16, 2017 at 8:19 PM, Amit Langote > wrote: >> Thanks for the review. I updated the comments. > > I found several more places that also needed to be updated using 'git > grep'. Committed with various additions.

Re: [HACKERS] NOT NULL constraints on range partition key columns

2017-05-18 Thread Robert Haas
On Tue, May 16, 2017 at 8:19 PM, Amit Langote wrote: > Thanks for the review. I updated the comments. I found several more places that also needed to be updated using 'git grep'. Committed with various additions. -- Robert Haas EnterpriseDB:

Re: [HACKERS] NOT NULL constraints on range partition key columns

2017-05-16 Thread Amit Langote
On 2017/05/16 21:16, Amit Kapila wrote: > On Tue, May 16, 2017 at 3:26 PM, Amit Langote > wrote: >> On 2017/05/16 4:29, Robert Haas wrote: >>> Yeah, that's exactly why I think we should make the change Amit is >>> proposing here. If we don't, then we won't be able

Re: [HACKERS] NOT NULL constraints on range partition key columns

2017-05-16 Thread Amit Kapila
On Tue, May 16, 2017 at 3:26 PM, Amit Langote wrote: > On 2017/05/16 4:29, Robert Haas wrote: >> On Mon, May 15, 2017 at 9:12 AM, Amit Kapila wrote: >>> Can't we allow NULL to get inserted into the partition (leaf >>> partition) if the user

Re: [HACKERS] NOT NULL constraints on range partition key columns

2017-05-16 Thread Amit Langote
On 2017/05/16 4:29, Robert Haas wrote: > On Mon, May 15, 2017 at 9:12 AM, Amit Kapila wrote: >> Can't we allow NULL to get inserted into the partition (leaf >> partition) if the user uses the partition name in Insert statement? > > That would be terrible behavior - the

Re: [HACKERS] NOT NULL constraints on range partition key columns

2017-05-15 Thread Robert Haas
On Mon, May 15, 2017 at 9:12 AM, Amit Kapila wrote: > Can't we allow NULL to get inserted into the partition (leaf > partition) if the user uses the partition name in Insert statement? That would be terrible behavior - the behavior of tuple routing should match the

Re: [HACKERS] NOT NULL constraints on range partition key columns

2017-05-15 Thread Amit Kapila
On Mon, May 15, 2017 at 11:46 AM, Amit Langote wrote: > Starting a new thread to discuss the proposal I put forward in [1] to stop > creating explicit NOT NULL constraint on range partition keys that are > simple columns. I said the following: > > On 2017/05/12

[HACKERS] NOT NULL constraints on range partition key columns

2017-05-15 Thread Amit Langote
Starting a new thread to discuss the proposal I put forward in [1] to stop creating explicit NOT NULL constraint on range partition keys that are simple columns. I said the following: On 2017/05/12 11:20, Robert Haas wrote: > On Thu, May 11, 2017 at 10:15 PM, Amit Langote >