Re: [HACKERS] NULL's support in SP-GiST

2012-03-09 Thread Tom Lane
Oleg Bartunov o...@sai.msu.su writes: attached patch introduces NULLs indexing for SP-GiST. With this patch Sp-GiST supports IS NULL, IS NOT NULL clauses, as well as full index scan. I've looked at this patch a bit. I share Jaime's extreme discomfort with re-using GIN code to handle some pages

Re: [HACKERS] NULL's support in SP-GiST

2012-03-07 Thread Robert Haas
On Tue, Feb 28, 2012 at 5:20 PM, Jaime Casanova ja...@2ndquadrant.com wrote: On Thu, Feb 2, 2012 at 4:26 PM, Oleg Bartunov o...@sai.msu.su wrote: attached patch introduces NULLs indexing for SP-GiST. With this patch Sp-GiST supports IS NULL, IS NOT NULL clauses, as well as full index scan. I

Re: [HACKERS] NULL's support in SP-GiST

2012-03-07 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: I guess the question is whether this is a stop-ship item for spgist. If it is, then we're going to have to spend the time to fix this, but if not, then since it was submitted more than two weeks after the start of the CommitFest, it seems we should

Re: [HACKERS] NULL's support in SP-GiST

2012-03-07 Thread Robert Haas
On Wed, Mar 7, 2012 at 4:03 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: I guess the question is whether this is a stop-ship item for spgist. If it is, then we're going to have to spend the time to fix this, but if not, then since it was submitted more than

Re: [HACKERS] NULL's support in SP-GiST

2012-02-28 Thread Jaime Casanova
On Thu, Feb 2, 2012 at 4:26 PM, Oleg Bartunov o...@sai.msu.su wrote: Hi there, attached patch introduces NULLs indexing for SP-GiST. With this patch Sp-GiST supports IS NULL, IS NOT NULL clauses, as well as full index scan. I was looking at this. It passes all regression tests, and seems to

[HACKERS] NULL's support in SP-GiST

2012-02-02 Thread Oleg Bartunov
Hi there, attached patch introduces NULLs indexing for SP-GiST. With this patch Sp-GiST supports IS NULL, IS NOT NULL clauses, as well as full index scan. We added boolean satisfyAll field in spgInnerConsistentIn and spgLeafConsistentIn structures, which informs the user-defined methods, that