Re: [HACKERS] New VACUUM FULL crashes on temp relations

2010-02-02 Thread Tom Lane
Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp writes: AFAICS, the assertion is broken, but the code is correct. We just need to adjust the expression in the assertion. I think this is 100% wrong. Toast tables shouldn't be changing namespace either; which means you broke something somewhere

Re: [HACKERS] New VACUUM FULL crashes on temp relations

2010-02-02 Thread Tom Lane
I wrote: Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp writes: AFAICS, the assertion is broken, but the code is correct. We just need to adjust the expression in the assertion. I think this is 100% wrong. Toast tables shouldn't be changing namespace either; which means you broke something

Re: [HACKERS] New VACUUM FULL crashes on temp relations

2010-02-02 Thread Tom Lane
I wrote: After tracing through it, the problem is that rebuild_relation() assumes toast tables are always in PG_TOAST_NAMESPACE; which has not been true since 8.3. CLUSTER has been renaming temp toast tables into the wrong namespace right along. Without the assert to call attention to it,

[HACKERS] New VACUUM FULL crashes on temp relations

2010-02-01 Thread Simon Riggs
TRAP: FailedAssertion(!(typeNamespace == typ-typnamespace), File: pg_type.c, Line: 658) Test case attached, repeated, consistent failure on CVS HEAD. Crash occurs with either CLUSTER or VACUUM FULL. Passed on without further investigation. -- Simon Riggs www.2ndQuadrant.com -- --

Re: [HACKERS] New VACUUM FULL crashes on temp relations

2010-02-01 Thread Takahiro Itagaki
Simon Riggs si...@2ndquadrant.com wrote: TRAP: FailedAssertion(!(typeNamespace == typ-typnamespace), File: pg_type.c, Line: 658) Test case attached, repeated, consistent failure on CVS HEAD. I see the same assertion failure on 8.4.2, too. I'll investigating it... -- minimum reproducible

Re: [HACKERS] New VACUUM FULL crashes on temp relations

2010-02-01 Thread Takahiro Itagaki
Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp wrote: TRAP: FailedAssertion(!(typeNamespace == typ-typnamespace), File: pg_type.c, Line: 658) It comes from swapping toast relations: DEBUG: typeNamespace mismatch: 99 (pg_toast) vs. 16386 (pg_toast_temp_2) AFAICS, the assertion is