Re: [HACKERS] New windows compiler warning from 585bca39

2014-04-18 Thread Bruce Momjian
On Thu, Apr 17, 2014 at 04:14:55PM -0400, Tom Lane wrote: > > Perhaps the #ifndef could be placed in a nicer spot in the patch, but the > > attached should at least describe where the problem lies... > > Yeah, I thought it better to make a separate declaration to wrap in > #ifndef. pgindent is pr

Re: [HACKERS] New windows compiler warning from 585bca39

2014-04-17 Thread Tom Lane
David Rowley writes: > I've attached a tiny patch that fixes a new compiler warning on the windows > build... Applied, thanks. > Perhaps the #ifndef could be placed in a nicer spot in the patch, but the > attached should at least describe where the problem lies... Yeah, I thought it better to m

[HACKERS] New windows compiler warning from 585bca39

2014-04-17 Thread David Rowley
I've attached a tiny patch that fixes a new compiler warning on the windows build... Perhaps the #ifndef could be placed in a nicer spot in the patch, but the attached should at least describe where the problem lies... (ClCompile target) -> src\interfaces\libpq\fe-connect.c(3365): warning C4101