[HACKERS] OK for ABI break of PlannerInfo in 8.4?

2010-03-30 Thread Tom Lane
Marc Cousins pointed out here http://archives.postgresql.org/pgsql-general/2010-03/msg01123.php that the constraint_exclusion = partition feature added in 8.4 does not do what you'd expect for the target relation of an UPDATE or DELETE. That's because expansion of an inheritance set is managed

Re: [HACKERS] OK for ABI break of PlannerInfo in 8.4?

2010-03-30 Thread Heikki Linnakangas
Tom Lane wrote: Marc Cousins pointed out here http://archives.postgresql.org/pgsql-general/2010-03/msg01123.php that the constraint_exclusion = partition feature added in 8.4 does not do what you'd expect for the target relation of an UPDATE or DELETE. That's because expansion of an

Re: [HACKERS] OK for ABI break of PlannerInfo in 8.4?

2010-03-30 Thread Tom Lane
Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: Seems OK to me. It's worth noting though that if a module does do palloc+memcpy of PlannerInfo, and it's compiled against the new sources with the extra field, but used on an old server version, it will memcpy() from beyond the end