[HACKERS] Optimizing GetConflictingVirtualXIDs()

2010-02-14 Thread Simon Riggs
Optimize GetConflictingVirtualXIDs() in roughly the same manner we optimize TransactionIdIsInProgress(). Views? -- Simon Riggs www.2ndQuadrant.com diff --git a/src/backend/storage/ipc/procarray.c b/src/backend/storage/ipc/procarray.c index 12de877..7f9b10e 100644 ---

Re: [HACKERS] Optimizing GetConflictingVirtualXIDs()

2010-02-14 Thread Greg Stark
On Sun, Feb 14, 2010 at 2:59 PM, Simon Riggs si...@2ndquadrant.com wrote: Optimize GetConflictingVirtualXIDs() in roughly the same manner we optimize TransactionIdIsInProgress(). Views? EINSUFFICIENTEXPLANATION :) -- greg -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Optimizing GetConflictingVirtualXIDs()

2010-02-14 Thread Simon Riggs
On Sun, 2010-02-14 at 17:06 +, Greg Stark wrote: On Sun, Feb 14, 2010 at 2:59 PM, Simon Riggs si...@2ndquadrant.com wrote: Optimize GetConflictingVirtualXIDs() in roughly the same manner we optimize TransactionIdIsInProgress(). Views? EINSUFFICIENTEXPLANATION :) ...I like that

Re: [HACKERS] Optimizing GetConflictingVirtualXIDs()

2010-02-14 Thread Tom Lane
Simon Riggs si...@2ndquadrant.com writes: On Sun, 2010-02-14 at 17:06 +, Greg Stark wrote: EINSUFFICIENTEXPLANATION :) ...I like that error code. I think more EINSUFFICIENTCOMMENTS. The patch should also add a comment to the function, along the lines of While we have the lock, also