In doLog, the sample rate test should be mixed in the tlogfile condition
so as to avoid calling rand if there is no logging anyway.
if (tlogfile sample_rate != 0 ...)
Oops, wrong logic. Rather:
if (tlogfile (sample_rate == 0 || ... random stuff))
--
Fabien.
--
Sent via
another thing that I find annoying on pgbench is that you can either log
aggregated summary (per interval) or detailed transaction info (possibly
sampled), but not both at the same time.
Here is a review.
Patch applied, compiled and run. Note that it needs a rebase after pgbench
move to
Hi,
another thing that I find annoying on pgbench is that you can either log
aggregated summary (per interval) or detailed transaction info (possibly
sampled), but not both at the same time.
That's annoying because what I generally use the aggregated info, but
sometimes the transaction info
