Re: [HACKERS] PG_MODULE_MAGIC checks and pg_migrator

2010-01-16 Thread Dimitri Fontaine
Bruce Momjian writes: > Another option would be to distribute both 8.4 and 8.5 shared objects, > but that would require access to two source trees to perform the > compile, which seems very error-prone. That's what any extension author and/or packager is faced with. Using debian, it's easy enough

Re: [HACKERS] PG_MODULE_MAGIC checks and pg_migrator

2010-01-14 Thread Tom Lane
Bruce Momjian writes: > For example, right now pg_migrator can migrate to 8.4 and 8.5, but there > is no way to distribute a binary that will migrate to both because you > need different shared libraries with different PG_MODULE_MAGIC values. [ yawn... ] By the time 8.5 (9.0?) ships, this will p

[HACKERS] PG_MODULE_MAGIC checks and pg_migrator

2010-01-14 Thread Bruce Momjian
Technically pg_migrator does not need the PG_MODULE_MAGIC version checks because it doesn't do any data manipulation and it already checks the new server version to determine if the function calls will resolve. However, we currently require PG_MODULE_MAGIC for all loaded libraries, and this adds a