Re: [HACKERS] PITR Redo Create Database fails

2004-07-09 Thread Simon Riggs
On Thu, 2004-07-08 at 20:14, Alvaro Herrera wrote: On Thu, Jul 08, 2004 at 06:33:56PM +0100, Simon Riggs wrote: On Thu, 2004-07-08 at 16:19, Alvaro Herrera wrote: On Thu, Jul 08, 2004 at 02:58:01PM +0100, Simon Riggs wrote: The correct solution would be to emit a XLog record for

[HACKERS] PITR Redo Create Database fails

2004-07-08 Thread Simon Riggs
I've discovered that CREATE DATABASE doesn't redo correctly in an archive recovery test. This isn't a bug --in the current code--, because when crash recovery occurs, the database directories are already there, so this only doesn't work when using the PITR patches. During archive recovery,

Re: [HACKERS] PITR Redo Create Database fails

2004-07-08 Thread Alvaro Herrera
On Thu, Jul 08, 2004 at 02:58:01PM +0100, Simon Riggs wrote: I've discovered that CREATE DATABASE doesn't redo correctly in an archive recovery test. This isn't a bug --in the current code--, because when crash recovery occurs, the database directories are already there, so this only

Re: [HACKERS] PITR Redo Create Database fails

2004-07-08 Thread Simon Riggs
On Thu, 2004-07-08 at 16:19, Alvaro Herrera wrote: On Thu, Jul 08, 2004 at 02:58:01PM +0100, Simon Riggs wrote: I've discovered that CREATE DATABASE doesn't redo correctly in an archive recovery test. This isn't a bug --in the current code--, because when crash recovery occurs, the

Re: [HACKERS] PITR Redo Create Database fails

2004-07-08 Thread Alvaro Herrera
On Thu, Jul 08, 2004 at 06:33:56PM +0100, Simon Riggs wrote: On Thu, 2004-07-08 at 16:19, Alvaro Herrera wrote: On Thu, Jul 08, 2004 at 02:58:01PM +0100, Simon Riggs wrote: The correct solution would be to emit a XLog record for CREATE DATABASE ... I'd prefer a formal approach, hence