Re: [HACKERS] PUBLICATIONS and pg_dump

2017-03-21 Thread Peter Eisentraut
On 2/26/17 14:25, Petr Jelinek wrote: > Yeah that was oversight in initial patch, publications and their > membership was supposed to be dumped only when table filter is not used. > I mistakenly made it check for data_only instead of using the > selectDumpableObject machinery. Committed. --

Re: [HACKERS] PUBLICATIONS and pg_dump

2017-02-26 Thread Petr Jelinek
On 08/02/17 05:02, Stephen Frost wrote: > Peter, > > On Tue, Feb 7, 2017 at 22:49 Peter Eisentraut > > wrote: > > On 2/7/17 3:19 PM, Stephen Frost wrote: > > I understand that this is a bit complicated, but I

Re: [HACKERS] PUBLICATIONS and pg_dump

2017-02-07 Thread Stephen Frost
Peter, On Tue, Feb 7, 2017 at 22:49 Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 2/7/17 3:19 PM, Stephen Frost wrote: > > I understand that this is a bit complicated, but I would have thought > > we'd do something similar to what is done for DEFAULT PRIVILEGES, where > > we

Re: [HACKERS] PUBLICATIONS and pg_dump

2017-02-07 Thread Peter Eisentraut
On 2/7/17 3:19 PM, Stephen Frost wrote: > I understand that this is a bit complicated, but I would have thought > we'd do something similar to what is done for DEFAULT PRIVILEGES, where > we include the "global" default privileges when we are doing a dump of > "everything", but if we're dumping a

[HACKERS] PUBLICATIONS and pg_dump

2017-02-07 Thread Stephen Frost
Peter, * Peter Eisentraut (pete...@gmx.net) wrote: > Logical replication > > - Add PUBLICATION catalogs and DDL > - Add SUBSCRIPTION catalog and DDL > - Define logical replication protocol and output plugin > - Add logical replication workers I think we need to have a bit more discussion