Re: [HACKERS] PageIndexTupleDelete

2009-12-06 Thread Tom Lane
Simon Riggs writes: > Having a special function that exists only for use in rare occasions > seems like a great recipe for sporadic corruption, if we are taking the > "paranoia seems justified" approach. It used to be called all the time, before some of the more popular paths got optimized into P

[HACKERS] PageIndexTupleDelete

2009-12-06 Thread Simon Riggs
Just noticed that PageIndexTupleDelete does not check that pd_special != MAXALIGN(pd_special) whereas PageIndexMultiDelete() does this. Both routines state that "paranoia seems justified", so this omission looks like an error. Looking a little deeper at this... We only call PageIndexTu