Re: [HACKERS] Partial Aggregation / GROUP BY before JOIN

2015-09-28 Thread Amit Langote
On 2015/09/28 20:58, David Rowley wrote: > On 28 September 2015 at 23:17, Amit Langote > wrote: >> Moreover, would partial aggregation work below Append? >> > > Do you mean for cases like: > > create table a as select x.x a from generate_series(1,100) x(x); > select sum(a) from (select a fro

Re: [HACKERS] Partial Aggregation / GROUP BY before JOIN

2015-09-28 Thread David Rowley
On 28 September 2015 at 23:17, Amit Langote wrote: > On 2015/09/28 17:04, David Rowley wrote: > > On 28 September 2015 at 20:36, Amit Langote < > langote_amit...@lab.ntt.co.jp> > > wrote: > > > >> > >> Did you perhaps attach a version of the patch you didn't intend to? > >> > > > > Oops. It seems

Re: [HACKERS] Partial Aggregation / GROUP BY before JOIN

2015-09-28 Thread Amit Langote
On 2015/09/28 17:04, David Rowley wrote: > On 28 September 2015 at 20:36, Amit Langote > wrote: > >> >> Did you perhaps attach a version of the patch you didn't intend to? >> > > Oops. It seems so. > > Please find the correct version attached. Thanks, this one works fine. By the way, you may

Re: [HACKERS] Partial Aggregation / GROUP BY before JOIN

2015-09-28 Thread David Rowley
On 28 September 2015 at 20:36, Amit Langote wrote: > > Did you perhaps attach a version of the patch you didn't intend to? > Oops. It seems so. Please find the correct version attached. Thanks for checking and letting me know. -- David Rowley http://www.2ndQuadrant.com/

Re: [HACKERS] Partial Aggregation / GROUP BY before JOIN

2015-09-28 Thread Amit Langote
On 2015/09/28 13:31, David Rowley wrote: > I've been spending time working on allowing the planner to perform > aggregation before the final join relation is created. > ... > > The patch is however so far capable of giving us extremely nice performance > improvements for some (likely artificial) q