Re: [HACKERS] Patch - Tcl 8.6 version support for PostgreSQL

2017-05-05 Thread Alvaro Herrera
Paresh More wrote: > Hello Alvaro, > > I applied the patch which you mentioned and tried compiling postgresql > server for windows 32 and 64 and the results are:- > > 1) postgresql server(96) with tcl version 8.5 is compiling fine with out > any issue. > 2) postgresql server(10) snapshot with

Re: [HACKERS] Patch - Tcl 8.6 version support for PostgreSQL

2017-05-05 Thread Paresh More
Hello Alvaro, I applied the patch which you mentioned and tried compiling postgresql server for windows 32 and 64 and the results are:- 1) postgresql server(96) with tcl version 8.5 is compiling fine with out any issue. 2) postgresql server(10) snapshot with tcl version 8.6 is also compiling

Re: [HACKERS] Patch - Tcl 8.6 version support for PostgreSQL

2017-05-04 Thread Dave Page
On Thu, May 4, 2017 at 3:54 PM, Tom Lane wrote: > Alvaro Herrera writes: > > Something like the (untested) attached perhaps? > > Looks plausible, I'm not in a position to test though. Sandeep/Paresh - can you test please? -- Dave Page Blog:

Re: [HACKERS] Patch - Tcl 8.6 version support for PostgreSQL

2017-05-04 Thread Tom Lane
Alvaro Herrera writes: > Something like the (untested) attached perhaps? Looks plausible, I'm not in a position to test though. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Patch - Tcl 8.6 version support for PostgreSQL

2017-05-04 Thread Alvaro Herrera
Tom Lane wrote: > But I agree with Andres' complaint that just duplicating the code isn't > the best way. The configure script has a loop that's basically like > > for f in tclsh tcl tclsh8.6 tclsh86 tclsh8.5 tclsh85 tclsh8.4 tclsh84 > tclsh8.3 tclsh83 > do >... break if $f is the right

Re: [HACKERS] Patch - Tcl 8.6 version support for PostgreSQL

2017-04-25 Thread Tom Lane
Michael Paquier writes: > On Tue, Apr 25, 2017 at 2:57 PM, Andres Freund wrote: >> Any chance of formulating these in a version agnostic way, instead of >> copying the same stanza for every version? E.g. using a wildcard or >> such... > Using

Re: [HACKERS] Patch - Tcl 8.6 version support for PostgreSQL

2017-04-25 Thread Michael Paquier
On Tue, Apr 25, 2017 at 2:57 PM, Andres Freund wrote: > Any chance of formulating these in a version agnostic way, instead of > copying the same stanza for every version? E.g. using a wildcard or > such... Using glob() would be enough for this purpose. -- Michael -- Sent

Re: [HACKERS] Patch - Tcl 8.6 version support for PostgreSQL

2017-04-24 Thread Andres Freund
Hi, On 2017-04-22 23:28:49 +0530, Sandeep Thakkar wrote: > diff --git a/src/tools/msvc/Mkvcbuild.pm b/src/tools/msvc/Mkvcbuild.pm > index 304edf9..d3ef89f 100644 > --- a/src/tools/msvc/Mkvcbuild.pm > +++ b/src/tools/msvc/Mkvcbuild.pm > @@ -253,7 +253,12 @@ sub mkvcbuild >

Re: [HACKERS] Patch - Tcl 8.6 version support for PostgreSQL

2017-04-24 Thread Sandeep Thakkar
On Tue, Apr 25, 2017 at 1:59 AM, Dave Page wrote: > > > On Mon, Apr 24, 2017 at 9:26 PM, Andres Freund wrote: > >> On 2017-04-24 16:18:30 -0400, Robert Haas wrote: >> > On Sat, Apr 22, 2017 at 1:58 PM, Sandeep Thakkar < >> >

Re: [HACKERS] Patch - Tcl 8.6 version support for PostgreSQL

2017-04-24 Thread Dave Page
On Mon, Apr 24, 2017 at 9:26 PM, Andres Freund wrote: > On 2017-04-24 16:18:30 -0400, Robert Haas wrote: > > On Sat, Apr 22, 2017 at 1:58 PM, Sandeep Thakkar < > > sandeep.thak...@enterprisedb.com> wrote: > > > > > Tcl8.6 is already supported in PostgreSQL. > > > > > > > What

Re: [HACKERS] Patch - Tcl 8.6 version support for PostgreSQL

2017-04-24 Thread Andres Freund
On 2017-04-24 16:18:30 -0400, Robert Haas wrote: > On Sat, Apr 22, 2017 at 1:58 PM, Sandeep Thakkar < > sandeep.thak...@enterprisedb.com> wrote: > > > Tcl8.6 is already supported in PostgreSQL. > > > > What commit added support for it? I don't think the main build mechanism requires explicit

Re: [HACKERS] Patch - Tcl 8.6 version support for PostgreSQL

2017-04-24 Thread Robert Haas
On Sat, Apr 22, 2017 at 1:58 PM, Sandeep Thakkar < sandeep.thak...@enterprisedb.com> wrote: > Tcl8.6 is already supported in PostgreSQL. > What commit added support for it? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [HACKERS] Patch - Tcl 8.6 version support for PostgreSQL

2017-04-22 Thread Sandeep Thakkar
Tcl8.6 is already supported in PostgreSQL. It was just missing the required changes for Windows build system. Can someone please review and commit the attached patches? - Mkvcbuild_Tcl86_94-92.patch (This applies to 9.4, 9.3 and 9.2) - Mkvcbuild_Tcl86_95-master.patch (This applies to 9.5, 9.6 and

[HACKERS] Patch - Tcl 8.6 version support for PostgreSQL

2017-04-20 Thread Paresh More
Hello Team This is regarding Tcl version (8.6) support in PostgreSQL. Currently in PostgreSQL server file (src/tools/msvc/Mkvcbuild.pm) it supports only till Tcl version 8.5 Attach patch contains adding Tcl 8.6 support. Please Note - In Tcl8.6, the library name now contains an extra 't" in