Re: [HACKERS] Patch LWlocks instrumentation

2009-09-14 Thread Pierre Frédéric Caillau d
Have you looked at the total execution time with and without the LWLOCK_TIMING_STATS? It didn't show any significant overhead on the little COPY test I made. On selects, it probably does (just like EXPLAIN ANALYZE), but I didn't test. It is not meant to be always active, it's a #define,

Re: [HACKERS] Patch LWlocks instrumentation

2009-09-14 Thread Jeff Janes
2009/9/14 Pierre Frédéric Caillaud > > A little bit of a reply to Jeff's email about WALInsertLock. > > This patch instruments LWLocks, it is controlled with the following > #define's in lwlock.c : > > LWLOCK_STATS > LWLOCK_TIMING_STATS > > It is an upgrade of current lwlocks stats. > Hi Pierre,

[HACKERS] Patch LWlocks instrumentation

2009-09-14 Thread Pierre Frédéric Caillau d
A little bit of a reply to Jeff's email about WALInsertLock. This patch instruments LWLocks, it is controlled with the following #define's in lwlock.c : LWLOCK_STATS LWLOCK_TIMING_STATS It is an upgrade of current lwlocks stats. When active, at backend exit, it will display stats as shown