Re: [HACKERS] Patch for str_numth() in PG 7.4

2009-01-13 Thread Alvaro Herrera
Tom Lane wrote: Alvaro Herrera alvhe...@commandprompt.com writes: This was fixed on 1.84 of formatting.c for 8.0 (but not backpatched for no apparent reason), which also changed some other stuff in that file. The complete patch is attached. I dunno why I didn't back-patch that; feel free

Re: [HACKERS] Patch for str_numth() in PG 7.4

2009-01-13 Thread Andreas 'ads' Scherbaum
On Tue, 13 Jan 2009 12:30:09 -0300 Alvaro Herrera wrote: The other cases were already handled, so Andreas' initial patch was enough -- applied. Thank you. Bye -- Andreas 'ads' Scherbaum German PostgreSQL User Group European PostgreSQL User Group - Board of

[HACKERS] Patch for str_numth() in PG 7.4

2009-01-12 Thread Andreas 'ads' Scherbaum
Hello, even if 7.4 is almost at the end of it's lifetime i found a bug/problem on a fairly new laptop (not surprising: during upgrade tests). All timestamp regression tests failed, only th was emitted. I tracked the problem done to the function str_numth() in src/backend/utils/adt/formatting.c.

Re: [HACKERS] Patch for str_numth() in PG 7.4

2009-01-12 Thread Gregory Stark
Andreas 'ads' Scherbaum adsm...@wars-nicht.de writes: I tracked the problem done to the function str_numth() in src/backend/utils/adt/formatting.c. The fix (attached) is easy: i stole the function code from the latest 8.0 version which looks fare more sane in handling the string pointers. I

Re: [HACKERS] Patch for str_numth() in PG 7.4

2009-01-12 Thread Andreas 'ads' Scherbaum
Hello all, On Mon, 12 Jan 2009 22:55:32 +0100 Andreas 'ads' Scherbaum wrote: I tracked the problem done to the function str_numth() in src/backend/utils/adt/formatting.c. The fix (attached) is easy: i stole the function code from the latest 8.0 version which looks fare more sane in handling

Re: [HACKERS] Patch for str_numth() in PG 7.4

2009-01-12 Thread Alvaro Herrera
Andreas 'ads' Scherbaum wrote: Hello all, On Mon, 12 Jan 2009 22:55:32 +0100 Andreas 'ads' Scherbaum wrote: I tracked the problem done to the function str_numth() in src/backend/utils/adt/formatting.c. The fix (attached) is easy: i stole the function code from the latest 8.0 version

Re: [HACKERS] Patch for str_numth() in PG 7.4

2009-01-12 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: This was fixed on 1.84 of formatting.c for 8.0 (but not backpatched for no apparent reason), which also changed some other stuff in that file. The complete patch is attached. I dunno why I didn't back-patch that; feel free to do so. Better do