Re: [HACKERS] Patch to add Windows 7 support

2009-01-28 Thread Magnus Hagander
Dave Page wrote: I don't think it's enough that we need to care about it really. I'm thinking we could perhaps even just never set that, and not bother with the version check... That was how I originally coded it, but figured we might as well set it if we can - it's not like it's expensive

[HACKERS] Patch to add Windows 7 support

2009-01-27 Thread Dave Page
The attached patch adds support for the Windows 7 beta which we've had a few reports of incompatibility with. When we startup using pg_ctl on Windows, we create a job object (a logical grouping of processes on Windows) to which we apply various security options. One of these

Re: [HACKERS] Patch to add Windows 7 support

2009-01-27 Thread Heikki Linnakangas
Dave Page wrote: The attached patch adds support for the Windows 7 beta which we've had a few reports of incompatibility with. When we startup using pg_ctl on Windows, we create a job object (a logical grouping of processes on Windows) to which we apply various security options. One of these

Re: [HACKERS] Patch to add Windows 7 support

2009-01-27 Thread Dave Page
On Tue, Jan 27, 2009 at 11:04 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Dave Page wrote: The attached patch adds support for the Windows 7 beta which we've had a few reports of incompatibility with. When we startup using pg_ctl on Windows, we create a job object (a

Re: [HACKERS] Patch to add Windows 7 support

2009-01-27 Thread Peter Eisentraut
On Tuesday 27 January 2009 12:34:56 Dave Page wrote: I'm not entirely sure what has change in the SCM to cause this yet (Windows 7 documentation is somewhat thin on the ground at the moment), but the patch avoids theporblem by only setting JOB_OBJECT_UILIMIT_HANDLES on earlier OSs. Doesn't

Re: [HACKERS] Patch to add Windows 7 support

2009-01-27 Thread Magnus Hagander
Peter Eisentraut wrote: On Tuesday 27 January 2009 12:34:56 Dave Page wrote: I'm not entirely sure what has change in the SCM to cause this yet (Windows 7 documentation is somewhat thin on the ground at the moment), but the patch avoids theporblem by only setting JOB_OBJECT_UILIMIT_HANDLES on

Re: [HACKERS] Patch to add Windows 7 support

2009-01-27 Thread Dave Page
On Tue, Jan 27, 2009 at 11:26 AM, Peter Eisentraut pete...@gmx.net wrote: On Tuesday 27 January 2009 12:34:56 Dave Page wrote: I'm not entirely sure what has change in the SCM to cause this yet (Windows 7 documentation is somewhat thin on the ground at the moment), but the patch avoids

Re: [HACKERS] Patch to add Windows 7 support

2009-01-27 Thread Dave Page
On Tue, Jan 27, 2009 at 11:38 AM, Magnus Hagander mag...@hagander.net wrote: Peter Eisentraut wrote: On Tuesday 27 January 2009 12:34:56 Dave Page wrote: I'm not entirely sure what has change in the SCM to cause this yet (Windows 7 documentation is somewhat thin on the ground at the moment),

Re: [HACKERS] Patch to add Windows 7 support

2009-01-27 Thread Tom Lane
Dave Page dp...@pgadmin.org writes: The attached patch adds support for the Windows 7 beta which we've had a few reports of incompatibility with. When we startup using pg_ctl on Windows, we create a job object (a logical grouping of processes on Windows) to which we apply various security

Re: [HACKERS] Patch to add Windows 7 support

2009-01-27 Thread Magnus Hagander
Tom Lane wrote: Dave Page dp...@pgadmin.org writes: The attached patch adds support for the Windows 7 beta which we've had a few reports of incompatibility with. When we startup using pg_ctl on Windows, we create a job object (a logical grouping of processes on Windows) to which we apply

Re: [HACKERS] Patch to add Windows 7 support

2009-01-27 Thread Dave Page
On Tue, Jan 27, 2009 at 3:11 PM, Tom Lane t...@sss.pgh.pa.us wrote: It would be good to understand what the problem actually is and what are the risks of running without this flag. I assume we put it in there for a reason. The risks are pretty low imho. Not having the flag means that the

Re: [HACKERS] Patch to add Windows 7 support

2009-01-27 Thread Tom Lane
Dave Page dp...@pgadmin.org writes: The risks are pretty low imho. Not having the flag means that the server has access to the handles of objects in other jobs in the same session. When running as a service, that's basically nothing as the service runs in it's own session and is isolated