Re: [PATCHES] [HACKERS] Patch to make Turks happy.

2002-12-09 Thread Bruce Momjian
Thanks. Applied for 7.3.1. --- Peter Eisentraut wrote: > Bruce Momjian writes: > > > Peter, is that patch OK for 7.3.1? I am not sure. > > Definitely. It's a bug fix. > > -- > Peter Eisentraut [EMAIL PROTECTED] >

Re: [PATCHES] [HACKERS] Patch to make Turks happy.

2002-12-09 Thread Peter Eisentraut
Bruce Momjian writes: > Peter, is that patch OK for 7.3.1? I am not sure. Definitely. It's a bug fix. -- Peter Eisentraut [EMAIL PROTECTED] ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (se

Re: [PATCHES] [HACKERS] Patch to make Turks happy.

2002-12-09 Thread Bruce Momjian
Peter, is that patch OK for 7.3.1? I am not sure. --- Peter Eisentraut wrote: > Bruce Momjian writes: > > > I am not going to apply this patch because I think it will mess up the > > handling of other locales. > > This pa

Re: [PATCHES] [HACKERS] Patch to make Turks happy.

2002-12-07 Thread Florian Weimer
Bruce Momjian <[EMAIL PROTECTED]> writes: > Are you 64-bit s390? The patch is for GNU/Linux on S/390 hardware. This platform is sane and it uses ASCII. Only the traditional UNIX subsystem for OS/390 uses EBCDIC. -- Florian Weimer[EMAIL PROTECTED] University of Stuttgart

Re: [PATCHES] [HACKERS] Patch to make Turks happy.

2002-12-06 Thread Bruce Momjian
Are you 64-bit s390? We have OS/390 patches in 7.4 but they were judged too risky for 7.3. Attached is the patch. Comment is: revision 1.103 date: 2002/11/22 01:13:16; author: tgl; state: Exp; lines: +29 -2 TAS code originally written for s390 (32-bit) does not work

Re: [PATCHES] [HACKERS] Patch to make Turks happy.

2002-12-06 Thread Florian Weimer
Nicolai Tufar <[EMAIL PROTECTED]> writes: > As far as I figured from the source code this function only deals > with cleaning up locale names and nothing else. Since all the locale > names are in plain ASCII I think it will be safe to use ASCII-only > lower-case conversion. Does PostgreSQL run on

Re: [PATCHES] [HACKERS] Patch to make Turks happy.

2002-12-05 Thread Bruce Momjian
OK, patch applied. Peter, should this appear in 7.3.1 too? --- Peter Eisentraut wrote: > Bruce Momjian writes: > > > I am not going to apply this patch because I think it will mess up the > > handling of other locales. >

Re: [PATCHES] [HACKERS] Patch to make Turks happy.

2002-12-05 Thread Bruce Momjian
OK, Peter, that helps. Thanks. I will apply it. --- Peter Eisentraut wrote: > Bruce Momjian writes: > > > I am not going to apply this patch because I think it will mess up the > > handling of other locales. > > This pat

Re: [PATCHES] [HACKERS] Patch to make Turks happy.

2002-12-05 Thread Peter Eisentraut
Bruce Momjian writes: > I am not going to apply this patch because I think it will mess up the > handling of other locales. This patch looks OK to me. Normally, character set names should use identifier case-folding rules anyway, so seems to be a step in the right direction. Much better than sa

Re: [HACKERS] Patch to make Turks happy.

2002-12-05 Thread Nicolai Tufar
Bruce Momjian wrote: I am not going to apply this patch because I think it will mess up the handling of other locales. As far as I figured from the source code this function only deals with cleaning up locale names and nothing else. Since all the locale names are in plain ASCII I think it will

Re: [HACKERS] Patch to make Turks happy.

2002-12-04 Thread Bruce Momjian
I am not going to apply this patch because I think it will mess up the handling of other locales. --- Nicolai Tufar wrote: > Hi, > > Yet another problem with Turkish encoding. clean_encoding_name() > in src/backend/utils/m

[HACKERS] Patch to make Turks happy.

2002-12-02 Thread Nicolai Tufar
Hi, Yet another problem with Turkish encoding. clean_encoding_name() in src/backend/utils/mb/encnames.c uses tolower() to convert locale names to lower-case. This causes errors if locale name contains capital "I" and current olcale is Turkish. Some examples: aaa=# \l List of databases Na