Re: [HACKERS] Patch to make pgindent work cleanly

2013-04-12 Thread Gurjeet Singh
On Fri, Apr 12, 2013 at 3:26 PM, Bruce Momjian wrote: > On Fri, Apr 12, 2013 at 01:34:49PM -0400, Gurjeet Singh wrote: > > Can you also improve the output when it dies upon failure to fetch > something? > > Currently the only error message it emits is "fetching xyz", and leaves > the > > user con

Re: [HACKERS] Patch to make pgindent work cleanly

2013-04-12 Thread Bruce Momjian
On Fri, Apr 12, 2013 at 01:34:49PM -0400, Gurjeet Singh wrote: > Can you also improve the output when it dies upon failure to fetch something? > Currently the only error message it emits is "fetching xyz", and leaves the > user confused as to what really the problem was. The only indication of a >

Re: [HACKERS] Patch to make pgindent work cleanly

2013-04-12 Thread Gurjeet Singh
On Fri, Apr 12, 2013 at 11:44 AM, Bruce Momjian wrote: > On Tue, Feb 19, 2013 at 04:50:45PM -0500, Gurjeet Singh wrote: > > Please find attached the patch for some cleanup and fix bit rot in > pgindent > > script. > > > > There were a few problems with the script. > > > > .) It failed to use the

Re: [HACKERS] Patch to make pgindent work cleanly

2013-04-12 Thread Bruce Momjian
On Tue, Feb 19, 2013 at 04:50:45PM -0500, Gurjeet Singh wrote: > Please find attached the patch for some cleanup and fix bit rot in pgindent > script. > > There were a few problems with the script. > > .) It failed to use the $ENV{PGENTAB} even if it was set. > .) The file it tries to download fr

[HACKERS] Patch to make pgindent work cleanly

2013-02-19 Thread Gurjeet Singh
Please find attached the patch for some cleanup and fix bit rot in pgindent script. There were a few problems with the script. .) It failed to use the $ENV{PGENTAB} even if it was set. .) The file it tries to download from Postgres' ftp site is no longer present. ftp://ftp.postgresql.org/pub/