On Sat, Jul 15, 2006 at 09:34:57AM -0400, Andrew Dunstan wrote:
> Neil Conway wrote:
> >We could annotate the source to indicate that some functions are
> >deliberately intended to be externally visible, but not referenced
> >within the source tree, and then teach find_static to grok that
> >annota
Neil Conway wrote:
On Sat, 2006-07-15 at 00:05 -0400, Tom Lane wrote:
The fundamental problem with find_static is that it hasn't got a clue
about likely future changes, nor about what we think external add-ons
might want
We could annotate the source to indicate that some functions are
RenameRewriteRule, and I defer to Teodor about the gist and gin
functions. The others range somewhere between "no" and "hell no".
I think that gistcentryinit() and extractEntriesS() should not be a
static.
---(end of broadcast)---
TIP 9: In
On Sat, 2006-07-15 at 00:05 -0400, Tom Lane wrote:
> The fundamental problem with find_static is that it hasn't got a clue
> about likely future changes, nor about what we think external add-ons
> might want
We could annotate the source to indicate that some functions are
deliberately intended to
Bruce Momjian <[EMAIL PROTECTED]> writes:
> Tom Lane wrote:
>> The fundamental problem with find_static is that it hasn't got a clue
>> about likely future changes, nor about what we think external add-ons
>> might want ...
> OK, I don't really have a clue either. Is any of it valid?
I don't obj
Tom Lane wrote:
> Bruce Momjian <[EMAIL PROTECTED]> writes:
> > Tom Lane wrote:
> >> This time around, please do not remove API functions just because you
> >> can't find a reference to them in the core code. I would like to see
> >> a posted, discussed patch first.
>
> > OK, here is my match to
Bruce Momjian <[EMAIL PROTECTED]> writes:
> Tom Lane wrote:
>> This time around, please do not remove API functions just because you
>> can't find a reference to them in the core code. I would like to see
>> a posted, discussed patch first.
> OK, here is my match to mark items as static or not us
Tom Lane wrote:
> [EMAIL PROTECTED] (Bruce Momjian) writes:
> > Have find_static skip main() functions.
>
> Uh-oh, don't tell me you are cranking up to run *that* thing again.
>
> This time around, please do not remove API functions just because you
> can't find a reference to them in the core co
