Re: [HACKERS] Per-column collation, the finale

2011-02-09 Thread Peter Eisentraut
On tis, 2011-02-08 at 22:17 +, Thom Brown wrote: postgres=# create table meow (id serial, stuff text collate de_XX); NOTICE: CREATE TABLE will create implicit sequence meow_id_seq for serial column meow.id ERROR: collation de_XX for current database encoding UTF8 does not exist LINE 1:

Re: [HACKERS] Per-column collation, the finale

2011-02-08 Thread Peter Eisentraut
On tor, 2011-02-03 at 18:36 -0500, Noah Misch wrote: Looks good and tests well. I've attached the same benchmark script with updated timings, and I've marked the patch Ready for Committer. Committed. Thanks everyone. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

Re: [HACKERS] Per-column collation, the finale

2011-02-08 Thread Thom Brown
On 8 February 2011 21:08, Peter Eisentraut pete...@gmx.net wrote: On tor, 2011-02-03 at 18:36 -0500, Noah Misch wrote: Looks good and tests well.  I've attached the same benchmark script with updated timings, and I've marked the patch Ready for Committer. Committed.  Thanks everyone. Awesome

Re: [HACKERS] Per-column collation, the finale

2011-02-04 Thread Bruce Momjian
Noah Misch wrote: On Thu, Feb 03, 2011 at 05:53:28PM +0200, Peter Eisentraut wrote: On tor, 2011-02-03 at 00:10 -0500, Noah Misch wrote: This is good stuff. I'll send you a new patch in a day or three for perhaps another round of performance tests. Some of the other issues

Re: [HACKERS] Per-column collation, the finale

2011-02-03 Thread Noah Misch
On Thu, Feb 03, 2011 at 05:53:28PM +0200, Peter Eisentraut wrote: On tor, 2011-02-03 at 00:10 -0500, Noah Misch wrote: This is good stuff. I'll send you a new patch in a day or three for perhaps another round of performance tests. Some of the other issues above can perhaps be

Re: [HACKERS] Per-column collation, the finale

2011-02-02 Thread Peter Eisentraut
On lör, 2011-01-29 at 02:52 -0500, Noah Misch wrote: I'm reviewing this patch as part of CommitFest 2011-01. Thank you very much for this thorough review. This no longer applies cleanly against git master, so I've done my testing against 52713d0. I will send an updated patch soon, when I

Re: [HACKERS] Per-column collation, the finale

2011-02-02 Thread Noah Misch
On Wed, Feb 02, 2011 at 11:20:44PM +0200, Peter Eisentraut wrote: On l??r, 2011-01-29 at 02:52 -0500, Noah Misch wrote: The new documentation is helpful. It would be useful to document the implications of marking your user-defined type COLLATABLE. As best I can tell, you should only

Re: [HACKERS] Per-column collation, the finale

2011-01-30 Thread Robert Haas
On Sat, Jan 29, 2011 at 2:52 AM, Noah Misch n...@leadboat.com wrote: The 13% slowdown with the feature unused seems worrisome Very worrisome. This is a frequently-requested feature, but this seems like a potential show-stopper. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The

Re: [HACKERS] Per-column collation, the finale

2011-01-28 Thread Noah Misch
Hi Peter, I'm reviewing this patch as part of CommitFest 2011-01. On Fri, Jan 14, 2011 at 11:41:46PM +0200, Peter Eisentraut wrote: I've been going over this patch with a fine-tooth comb for the last two weeks, fixed some small bugs, added comments, made initdb a little friendlier, but no

Re: [HACKERS] Per-column collation, the finale

2011-01-25 Thread Peter Eisentraut
On tis, 2011-01-25 at 10:14 +0900, Itagaki Takahiro wrote: On Sat, Jan 15, 2011 at 06:41, Peter Eisentraut pete...@gmx.net wrote: I've been going over this patch with a fine-tooth comb for the last two weeks, fixed some small bugs, added comments, made initdb a little friendlier, but no

Re: [HACKERS] Per-column collation, the finale

2011-01-25 Thread Noah Misch
On Wed, Jan 26, 2011 at 12:35:07AM +0200, Peter Eisentraut wrote: On tis, 2011-01-25 at 10:14 +0900, Itagaki Takahiro wrote: and I have an almost empty pg_collation catalog with it: =# SELECT * FROM pg_collation; collname | collnamespace | collencoding | collcollate | collctype

Re: [HACKERS] Per-column collation, the finale

2011-01-24 Thread Itagaki Takahiro
On Sat, Jan 15, 2011 at 06:41, Peter Eisentraut pete...@gmx.net wrote: I've been going over this patch with a fine-tooth comb for the last two weeks, fixed some small bugs, added comments, made initdb a little friendlier, but no substantial changes. What can I do to test the patch? No

Re: [HACKERS] Per-column collation, the finale

2011-01-14 Thread Robert Haas
On Fri, Jan 14, 2011 at 4:41 PM, Peter Eisentraut pete...@gmx.net wrote: I've been going over this patch with a fine-tooth comb for the last two weeks, fixed some small bugs, added comments, made initdb a little friendlier, but no substantial changes. I'm going to start working on SQL-level

Re: [HACKERS] Per-column collation, the finale

2011-01-14 Thread Euler Taveira de Oliveira
Em 14-01-2011 20:47, Robert Haas escreveu: On Fri, Jan 14, 2011 at 4:41 PM, Peter Eisentrautpete...@gmx.net wrote: I've been going over this patch with a fine-tooth comb for the last two weeks, fixed some small bugs, added comments, made initdb a little friendlier, but no substantial changes.