RE: [HACKERS] Permissions on CHECKPOINT

2001-01-26 Thread Mikheev, Vadim
Yes, there should be permission checking - I'll add it later (in 7.1) if no one else. Should be simple enough. Is this okay: I think yes - please apply. Vadim

RE: [HACKERS] Permissions on CHECKPOINT

2001-01-26 Thread Mikheev, Vadim
Actually, I think a more interesting question is "should CHECKPOINT have permission restrictions? If so, what should they be?" A quite relevant precedent is that Unix systems (at least the ones I've used) do not restrict who can call sync(). Checkpoints 1. affect entire system, 2.

Re: [HACKERS] Permissions on CHECKPOINT

2001-01-26 Thread Bruce Momjian
Tom Lane wrote: Peter Eisentraut [EMAIL PROTECTED] writes: Mikheev, Vadim writes: Yes, there should be permission checking - I'll add it later (in 7.1) if no one else. Should be simple enough. Is this okay: Actually, I think a more interesting question is "should

Re: [HACKERS] Permissions on CHECKPOINT

2001-01-26 Thread Bruce Momjian
[ Charset ISO-8859-1 unsupported, converting... ] What about DoS attacks? What would be the effect of someone's setting off an infinite loop of CHECKPOINTs? Don't we have bigger DoS attacks? Certainly SELECT cash_out(1) is a much bigger one. I've missed point - cash_out(1) is

Re: [HACKERS] Permissions on CHECKPOINT

2001-01-26 Thread Tom Lane
Okay, okay, complaint withdrawn. Peter, would you commit that permission check? regards, tom lane

RE: [HACKERS] Permissions on CHECKPOINT

2001-01-25 Thread Peter Eisentraut
Mikheev, Vadim writes: Yes, there should be permission checking - I'll add it later (in 7.1) if no one else. Should be simple enough. Is this okay: Index: utility.c === RCS file:

Re: [HACKERS] Permissions on CHECKPOINT

2001-01-25 Thread Tom Lane
Peter Eisentraut [EMAIL PROTECTED] writes: Mikheev, Vadim writes: Yes, there should be permission checking - I'll add it later (in 7.1) if no one else. Should be simple enough. Is this okay: Actually, I think a more interesting question is "should CHECKPOINT have permission restrictions?

Re: [HACKERS] Permissions on CHECKPOINT

2001-01-25 Thread Oliver Elphick
Tom Lane wrote: Peter Eisentraut [EMAIL PROTECTED] writes: Mikheev, Vadim writes: Yes, there should be permission checking - I'll add it later (in 7.1) if no one else. Should be simple enough. Is this okay: Actually, I think a more interesting question is "should CHECKPOINT

Re: [HACKERS] Permissions on CHECKPOINT

2001-01-24 Thread Oliver Elphick
Peter Eisentraut wrote: Contrary to what the submitted documentation claims, there is no permission checking done on the CHECKPOINT command. Should there be? Vadim seemed to indicate that he was going to make that restriction. Perhaps I misunderstood. If it's too late to make the change

RE: [HACKERS] Permissions on CHECKPOINT

2001-01-24 Thread Mikheev, Vadim
Contrary to what the submitted documentation claims, there is no permission checking done on the CHECKPOINT command. Should there be? Vadim seemed to indicate that he was going to make that restriction. Perhaps I misunderstood. Yes, there should be permission checking - I'll add