Re: [HACKERS] Possible spelling fixes

0001-spelling-comments.patch Description: Binary data 0002-spelling-strings.patch Description: Binary data 0003-spelling-sgml.patch Description: Binary data 0004-spelling-variables.patch Description: Binary data 0005-spelling-misc.patch Description: Binary data -- Sent via

Re: [HACKERS] Possible spelling fixes

On 2017-03-01 14:40:26 -0300, Alvaro Herrera wrote: > Josh Soref wrote: > > > One thing that would be helpful is if someone could comment on: > > https://github.com/jsoref/postgres/commit/9050882d601134ea1ba26f77ce5f1aaed75418de > > -#undef SH_ITERTOR > > +#undef SH_ITERATOR > > > > It's unclear

Re: [HACKERS] Possible spelling fixes

Josh Soref wrote: > One thing that would be helpful is if someone could comment on: > https://github.com/jsoref/postgres/commit/9050882d601134ea1ba26f77ce5f1aaed75418de > -#undef SH_ITERTOR > +#undef SH_ITERATOR > > It's unclear to me what that line is/was doing. It's possible that it > could be

Re: [HACKERS] Possible spelling fixes

Peter Eisentraut wrote: > Yes, some of that was committed, and some comments were offered. If > there is more to do, please send a rebased patch set. Conflicting comments were offered. And Heikki requested I send along the remainder. Which I did. Only one of those patches would have been

Re: [HACKERS] Possible spelling fixes

I'll include it. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Possible spelling fixes

I understood that they were git commits. I could have excluded the file but opted not to in case people were willing to take a small drift -- the SHAs are what someone needs to review the commit, and personally, I'd rather read something without typos than with -- especially in a summary. But,

Re: [HACKERS] Possible spelling fixes

I can easily drop the shutdown* items; The reason for rowMarks is consistency with lr_arowMarks. I'll tentatively exclude that from any resubmission I make tonight... -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Possible spelling fixes

Josh Soref wrote: > >

Re: [HACKERS] Possible spelling fixes

Josh Soref wrote: > - else if (ControlFile->state == DB_SHUTDOWNING) > + else if (ControlFile->state == DB_SHUTTINGDOWN) SHUTDOWNING and SHUTDOWNED are typos first introduced by hacker emeritus Vadim Mikheev in 1999 together with WAL, commit 47937403676d. It goes to show that not every

Re: [HACKERS] Possible spelling fixes

On 3/1/17 09:12, Josh Soref wrote: > On Mar 1, 2017 9:06 AM, "Peter Eisentraut" > > wrote: > > On 2/6/17 06:03, Heikki Linnakangas wrote: > > Ah, yes please. Post them over and I'll have a look at those as well.

Re: [HACKERS] Possible spelling fixes

On 6 February 2017 at 15:50, Josh Soref wrote: > It's now split more or less to your suggestion: > https://github.com/jsoref/postgres/commits/spelling - * Note that this algrithm is know to not be very effective (O(N^2)) + * Note that this algorithm is know to not be very

Re: [HACKERS] Possible spelling fixes

On Mar 1, 2017 9:06 AM, "Peter Eisentraut" wrote: On 2/6/17 06:03, Heikki Linnakangas wrote: > Ah, yes please. Post them over and I'll have a look at those as well. This thread is in the commit fest, but I think there is no current patch. I sent email on the

Re: [HACKERS] Possible spelling fixes

On 2/6/17 06:03, Heikki Linnakangas wrote: > On 02/06/2017 12:52 PM, Josh Soref wrote: >> Did you want me to submit emails for the remaining portions from >> https://github.com/jsoref/postgres/commits/spelling > > Ah, yes please. Post them over and I'll have a look at those as well. This thread

Re: [HACKERS] Possible spelling fixes

diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -6083,7 +6083,7 @@ StartupXLOG(void) ereport(LOG, (errmsg("database system was

Re: [HACKERS] Possible spelling fixes

diff --git a/src/test/regress/sql/plpgsql.sql b/src/test/regress/sql/plpgsql.sql --- a/src/test/regress/sql/plpgsql.sql +++ b/src/test/regress/sql/plpgsql.sql @@ -2219,15 +2219,15 @@ drop type eitype cascade; -- SQLSTATE and SQLERRM test -- -create function excpt_test1() returns void as $$

Re: [HACKERS] Possible spelling fixes

diff --git a/src/backend/access/transam/multixact.c b/src/backend/access/transam/multixact.c --- a/src/backend/access/transam/multixact.c +++ b/src/backend/access/transam/multixact.c @@ -3342,7 +3342,7 @@ pg_get_multixact_members(PG_FUNCTION_ARG } mxact; MultiXactId mxid =

Re: [HACKERS] Possible spelling fixes

diff --git a/contrib/ltree/ltxtquery_io.c b/contrib/ltree/ltxtquery_io.c --- a/contrib/ltree/ltxtquery_io.c +++ b/contrib/ltree/ltxtquery_io.c @@ -96,7 +96,7 @@ gettoken_query(QPRS_STATE *state, int32 if (*flag)

Re: [HACKERS] Possible spelling fixes

On 2017-02-06 10:40, Heikki Linnakangas wrote: > On 02/06/2017 04:50 AM, Josh Soref wrote: >> NUL-terminated -> NULL-terminated > > When we're talking about NUL-terminated strings, NUL refers to the NUL > ASCII character. NULL usually refers to a NULL pointer. We're probably > not consistent

Re: [HACKERS] Possible spelling fixes

Andres Freund wrote: > On 2017-02-05 21:05:50 -0500, Josh Soref wrote: > > A complete diff would be roughly 130k. I've recently tried to submit a > > similarly sized patch to another project and it was stuck in > > moderation (typically mailing lists limit attachments to around 40k). > > IIRC

Re: [HACKERS] Possible spelling fixes

On 02/06/2017 12:52 PM, Josh Soref wrote: Did you want me to submit emails for the remaining portions from https://github.com/jsoref/postgres/commits/spelling Ah, yes please. Post them over and I'll have a look at those as well. - Heikki -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Possible spelling fixes

Heikki wrote: ‎> I pushed most of these. Except for the below: > optimisation -> optimization et al. > Most of our code is written with the American spelling, > but the British spelling isn't wrong, > so I don't want to go around changing them all. Sure As you'll see, my approach is to aim for

Re: [HACKERS] Possible spelling fixes

On 02/06/2017 04:50 AM, Josh Soref wrote: It's now split more or less to your suggestion: https://github.com/jsoref/postgres/commits/spelling Thanks! I pushed most of these. Except for the below: optimisation -> optimization et al. Most of our code is written with the American spelling,

Re: [HACKERS] Possible spelling fixes

It's now split more or less to your suggestion: https://github.com/jsoref/postgres/commits/spelling diff --git a/configure b/configure --- a/configure +++ b/configure @@ -7088,7 +7088,7 @@ test -z "$INSTALL_SCRIPT" && INSTALL_SCR test -z "$INSTALL_DATA" && INSTALL_DATA='${INSTALL} -m 644' #

Re: [HACKERS] Possible spelling fixes

Hi, On 2017-02-05 21:05:50 -0500, Josh Soref wrote: > Could someone please review the changes I have [3] and suggest a > series of commits that this project might like? I think the current split seem excessive... I'd suggest splitting things first into: - straight up spelling/typo fixes in

[HACKERS] Possible spelling fixes

Hi. I'm going through project-by-project offering spelling fixes. I have read your submission suggestions [1][2] and am choosing to disregard them. Could someone please review the changes I have [3] and suggest a series of commits that this project might like? It is quite likely that someone