Re: [HACKERS] PostgreSQL 10 (latest beta) and older ICU

2017-08-05 Thread Peter Eisentraut
On 8/1/17 11:28, Peter Eisentraut wrote: > On 8/1/17 08:28, Victor Wagner wrote: >> On Tue, 1 Aug 2017 08:16:54 -0400 >> Peter Eisentraut wrote: >> >>> On 8/1/17 02:12, Victor Wagner wrote: > We are only calling uloc_toLanguageTag() with keyword/value > combinations that ICU itself previou

Re: [HACKERS] PostgreSQL 10 (latest beta) and older ICU

2017-08-01 Thread Peter Eisentraut
On 8/1/17 08:28, Victor Wagner wrote: > On Tue, 1 Aug 2017 08:16:54 -0400 > Peter Eisentraut wrote: > >> On 8/1/17 02:12, Victor Wagner wrote: We are only calling uloc_toLanguageTag() with keyword/value combinations that ICU itself previously told us were supported. So just ignori

Re: [HACKERS] PostgreSQL 10 (latest beta) and older ICU

2017-08-01 Thread Tom Lane
Victor Wagner writes: > Peter Eisentraut wrote: >> I don't know that we can already reach that conclusion. Maybe the > Because it was fixed in subsequent versions. > And 4.2 is first version where this function appeared. > So, we still have problems with SLES11 which use even older version and

Re: [HACKERS] PostgreSQL 10 (latest beta) and older ICU

2017-08-01 Thread Victor Wagner
On Tue, 1 Aug 2017 08:16:54 -0400 Peter Eisentraut wrote: > On 8/1/17 02:12, Victor Wagner wrote: > >> We are only calling uloc_toLanguageTag() with keyword/value > >> combinations that ICU itself previously told us were supported. So > >> just ignoring errors doesn't seem proper in this case. >

Re: [HACKERS] PostgreSQL 10 (latest beta) and older ICU

2017-08-01 Thread Peter Eisentraut
On 8/1/17 02:12, Victor Wagner wrote: >> We are only calling uloc_toLanguageTag() with keyword/value >> combinations that ICU itself previously told us were supported. So >> just ignoring errors doesn't seem proper in this case. >> > We know that this version of ICU is broken. But what choice we h

Re: [HACKERS] PostgreSQL 10 (latest beta) and older ICU

2017-07-31 Thread Victor Wagner
On Mon, 31 Jul 2017 19:42:30 -0400 Peter Eisentraut wrote: > On 7/25/17 15:20, Victor Wagner wrote: > > It turns out, that PostgreSQL enumerates collations for all ICU > > locales and passes it into uloc_toLanguageTag function with strict > > argument of this function set to TRUE. But for some lo

Re: [HACKERS] PostgreSQL 10 (latest beta) and older ICU

2017-07-31 Thread Peter Eisentraut
On 7/25/17 15:20, Victor Wagner wrote: > It turns out, that PostgreSQL enumerates collations for all ICU locales > and passes it into uloc_toLanguageTag function with strict argument of > this function set to TRUE. But for some locales > (es*@collation=tradtiional, si*@collation=dictionary) only ca

Re: [HACKERS] PostgreSQL 10 (latest beta) and older ICU

2017-07-25 Thread Victor Wagner
On Tue, 25 Jul 2017 16:50:38 -0400 Tom Lane wrote: > Victor Wagner writes: > > PostgreSQL 10 when build with --with-icu requires ICU 4.6 and above. > > (because it searches for libicu using pkgconfig, and pgkconfig > > support significantly changed in ICU version 4.6) > > > However, there ar

Re: [HACKERS] PostgreSQL 10 (latest beta) and older ICU

2017-07-25 Thread Tom Lane
Victor Wagner writes: > PostgreSQL 10 when build with --with-icu requires ICU 4.6 and above. > (because it searches for libicu using pkgconfig, and pgkconfig support > significantly changed in ICU version 4.6) > However, there are some reasons to build PostgreSQL with older versions > of ICU.

[HACKERS] PostgreSQL 10 (latest beta) and older ICU

2017-07-25 Thread Victor Wagner
Collegues, PostgreSQL 10 when build with --with-icu requires ICU 4.6 and above. (because it searches for libicu using pkgconfig, and pgkconfig support significantly changed in ICU version 4.6) However, there are some reasons to build PostgreSQL with older versions of ICU. For instance such Lin