On Wed, Dec 9, 2015 at 11:23 AM, Robert Haas wrote:
> Boy, that's awful. Whoever designed that bit of wonderfulness should
> have their language design license revoked.
If one would want to work on a check with pidfile, he/she could check
for tell($pidfile) == -1 which corresponds to an undetermi
On Tue, Dec 8, 2015 at 6:09 PM, Michael Paquier
wrote:
> On Wed, Dec 9, 2015 at 4:47 AM, Robert Haas wrote:
>> On Thu, Dec 3, 2015 at 11:28 PM, Michael Paquier
>> wrote:
>> > This does not impact the run, but it creates unwelcome warnings in the
>> > logs. This is actually caused by the followin
On Wed, Dec 9, 2015 at 8:57 AM, Alvaro Herrera wrote:
> Michael Paquier wrote:
>
>> This code should have checked for the return result of open instead of
>> looking at $pidfile. This has been noticed by Noah as well afterwards
>> and already addressed as 9821492.
>
> Oops, sorry I didn't credit y
Michael Paquier wrote:
> This code should have checked for the return result of open instead of
> looking at $pidfile. This has been noticed by Noah as well afterwards
> and already addressed as 9821492.
Oops, sorry I didn't credit you in the commit message.
--
Álvaro Herrerahtt
On Wed, Dec 9, 2015 at 4:47 AM, Robert Haas wrote:
>
> On Thu, Dec 3, 2015 at 11:28 PM, Michael Paquier
> wrote:
> > This does not impact the run, but it creates unwelcome warnings in the
> > logs. This is actually caused by the following code in PostgresNode
> > that uses an incorrect check to s
On Thu, Dec 3, 2015 at 11:28 PM, Michael Paquier
wrote:
> This does not impact the run, but it creates unwelcome warnings in the
> logs. This is actually caused by the following code in PostgresNode
> that uses an incorrect check to see if the file has been correctly
> opened or not:
> open my
Hi all,
While running the test suite this morning I have noticed the following error:
server stopped
readline() on closed filehandle $pidfile at
/Users/ioltas/git/postgres/src/bin/pg_rewind/../../../src/test/perl/PostgresNode.pm
line 308.
Use of uninitialized value in concatenation (.) or string a
