On 4/19/16 10:23 PM, Noah Misch wrote:
3. Because we use sed we do not tests for plpython3 under Windows. And I
> have trouble with CMake too.
Even if removing regress-python3-mangle.mk happened to be good for PL/Python,
we need build systems flexible enough to implement steps like it without a
Yury Zhuravlev writes:
> Tom Lane wrote:
>> Also, I would bet that those tools would not know anything
>> about converting PL language names between 'plpythonu' and 'plpython2u'
>> and 'plpython3u'; so even if we used one of them, we would still need a
>> layer pretty similar to what we have.
> I
Tom Lane wrote:
Also, I would bet that those tools would not know anything
about converting PL language names between 'plpythonu' and 'plpython2u'
and 'plpython3u'; so even if we used one of them, we would still need a
layer pretty similar to what we have.
I do not see this as a problem because
Yury Zhuravlev writes:
> Noah Misch wrote:
>> I may not understand that second sentence. We have multiple buildfarm
>> members
>> verifying the python2 case and multiple members verifying the python3 case.
> I wrote about special python3 features what not testing today. We testing
> Python3 as
Noah Misch wrote:
Considering we have 2756 lines of Python test SQL and just thirteen lines of
sed to mangle them, the current method is scaling nicely.
What pitfalls hides this approach? Convert python2 code to python3 it is
really bad practice.
I may not understand that second sentence. We
On Tue, Apr 19, 2016 at 06:31:34PM +0300, Yury Zhuravlev wrote:
> Now we generate tests for plpython3 of plpython2 tests. I think we should
> write independently 2 test suite.
> Why is that bad:
> 1. Differences between python2 and python3 more than can be solved by
> regexps. And these differences
Hello.
Now we generate tests for plpython3 of plpython2 tests. I think we should
write independently 2 test suite.
Why is that bad:
1. Differences between python2 and python3 more than can be solved by
regexps. And these differences are growing.
2. We must be careful to write tests, so as not t
