Re: [HACKERS] Proposal: improve shutdown during online backup

2008-03-27 Thread Albe Laurenz
Greg Smith wrote: > > 1) On "pg_ctl stop|restart -m smart", check if online backup is > > in progress and do not shutdown in this case (treat the online > > backup like an open connection). > > As long as you give a warning as to the cause. While you're in there, I > think more output in gen

Re: [HACKERS] Proposal: improve shutdown during online backup

2008-03-26 Thread Greg Smith
On Wed, 26 Mar 2008, Albe Laurenz wrote: 1) On "pg_ctl stop|restart -m smart", check if online backup is in progress and do not shutdown in this case (treat the online backup like an open connection). As long as you give a warning as to the cause. While you're in there, I think more outp

Re: [HACKERS] Proposal: improve shutdown during online backup

2008-03-26 Thread Simon Riggs
On Wed, 2008-03-26 at 14:36 +0100, Albe Laurenz wrote: > I'm referring to the discussion in this thread: > http://archives.postgresql.org/pgsql-hackers/2007-11/msg00946.php > > As expressed in the thread, I think that there should not be > a backup_label file in the data directory after a clean sh

[HACKERS] Proposal: improve shutdown during online backup

2008-03-26 Thread Albe Laurenz
I'm referring to the discussion in this thread: http://archives.postgresql.org/pgsql-hackers/2007-11/msg00946.php As expressed in the thread, I think that there should not be a backup_label file in the data directory after a clean shutdown, because a) it's probably an oversight anyway (someone for