Re: [HACKERS] Proposal for updatable views

2006-06-16 Thread Bruce Momjian
URL added to TODO. I assume there has been no more progress on this patch. --- Bernd Helmle wrote: > Hi folks, > > Please find attached a patch that implements SQL92-compatible updatable > views. The patch introduces new

Re: [HACKERS] Proposal for updatable views

2006-03-14 Thread Andrew Dunstan
Tom Lane wrote: Worst case is we promote WITH to a fully reserved word. While I don't normally care for doing that, it *is* a reserved word per SQL99, and offhand I don't see likely scenarios for someone using "with" as a table or column or function name. (Anyone know of a language in which "w

Re: [HACKERS] Proposal for updatable views

2006-03-13 Thread William ZHANG
> A quick look at the grammar suggests that the key problem is the > opt_timezone production --- it might be that if we removed that in > favor of spelling out the alternatives at the call sites, the conflict > would go away. bison-fu is all about postponing shift/reduce decisions > until you've s

Re: [HACKERS] Proposal for updatable views

2006-03-13 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > On Sun, 2006-03-12 at 23:39 +0800, William ZHANG wrote: >> Maybe you can fix it like UNIONJOIN. > Indeed, that is one option. Not any more ;-) > It would be unfortunate to revert the change, but I doubt the overhead > is very significant. Does anyone hav

Re: [HACKERS] Proposal for updatable views

2006-03-13 Thread Neil Conway
On Sun, 2006-03-12 at 23:39 +0800, William ZHANG wrote: > Maybe you can fix it like UNIONJOIN. Indeed, that is one option. Because the syntax is WITH [ LOCAL | CASCADED ] CHECK OPTION, ISTM we'll actually need three new tokens: WITH_LOCAL, WITH_CASCADED, and WITH_CHECK, which is even uglier :-( Pe

Re: [HACKERS] Proposal for updatable views

2006-03-13 Thread Jaime Casanova
On 3/13/06, Bernd Helmle <[EMAIL PROTECTED]> wrote: > > > --On Sonntag, März 12, 2006 23:52:12 -0500 Neil Conway <[EMAIL PROTECTED]> > wrote: > > > On Fri, 2006-03-10 at 11:21 +0100, Bernd Helmle wrote: > >> Please find attached a patch that implements SQL92-compatible updatable > >> views. > > > >

Re: [HACKERS] Proposal for updatable views

2006-03-13 Thread Bernd Helmle
--On Sonntag, März 12, 2006 23:52:12 -0500 Neil Conway <[EMAIL PROTECTED]> wrote: On Fri, 2006-03-10 at 11:21 +0100, Bernd Helmle wrote: Please find attached a patch that implements SQL92-compatible updatable views. I'm currently reviewing this. Comments later... ok Please note t

Re: [HACKERS] Proposal for updatable views

2006-03-12 Thread Neil Conway
On Fri, 2006-03-10 at 11:21 +0100, Bernd Helmle wrote: > Please find attached a patch that implements SQL92-compatible updatable > views. I'm currently reviewing this. Comments later... > Please note that the patch isn't complete yet Do you have a list of known TODO items? -Neil ---

Re: [HACKERS] Proposal for updatable views

2006-03-12 Thread William ZHANG
"Bernd Helmle" <[EMAIL PROTECTED]> > Hi folks, > The supported syntax is > > CREATE VIEW foo AS SELECT ... [WITH [LOCAL | CASCADED] CHECK OPTION]; > > The LOCAL and CASCADED keywords are optional when a CHECK OPTION is > specified, the default is CASCADED (this syntax creates a shift/reduce > conf

[HACKERS] Proposal for updatable views

2006-03-10 Thread Bernd Helmle
Hi folks, Please find attached a patch that implements SQL92-compatible updatable views. The patch introduces new semantics into the rule system: implicit and explicit rules. Implicit rules are created to implement updatable views: _INSERT _NOTHING_INSERT (unconditional DO INSTEAD NOTHING rul