Re: [HACKERS] PushActiveSnapshot(GetTransactionSnapshot())

2011-08-23 Thread Alvaro Herrera
Excerpts from Simon Riggs's message of mar ago 23 10:56:17 -0300 2011: > On Mon, Aug 22, 2011 at 7:07 PM, Alvaro Herrera > wrote: > > Excerpts from Simon Riggs's message of dom ago 21 16:23:39 -0300 2011: > >> In common cases of snapshot use we run GetSnapshotData() into a > >> statically allocate

Re: [HACKERS] PushActiveSnapshot(GetTransactionSnapshot())

2011-08-23 Thread Simon Riggs
On Mon, Aug 22, 2011 at 7:07 PM, Alvaro Herrera wrote: > Excerpts from Simon Riggs's message of dom ago 21 16:23:39 -0300 2011: >> In common cases of snapshot use we run GetSnapshotData() into a >> statically allocated snapshot, then immediately copy the static struct >> into a dynamically allocat

Re: [HACKERS] PushActiveSnapshot(GetTransactionSnapshot())

2011-08-22 Thread Alvaro Herrera
Excerpts from Simon Riggs's message of dom ago 21 16:23:39 -0300 2011: > In common cases of snapshot use we run GetSnapshotData() into a > statically allocated snapshot, then immediately copy the static struct > into a dynamically allocated copy. > > The static allocation was designed to remove th

[HACKERS] PushActiveSnapshot(GetTransactionSnapshot())

2011-08-21 Thread Simon Riggs
In common cases of snapshot use we run GetSnapshotData() into a statically allocated snapshot, then immediately copy the static struct into a dynamically allocated copy. The static allocation was designed to remove the overhead of dynamic allocation, but then we do it anyway. The snapmgr code doe