Re: [HACKERS] Question about src/timezone/zic.c

2014-07-16 Thread Tom Lane
Stephen Frost writes: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> One thing that *would* be worth doing is merging upstream's recent >> updates; for all I know they've already dealt with this. According >> to the README, we last synced with the 2010c tzcode release, so we're >> short a few years

Re: [HACKERS] Question about src/timezone/zic.c

2014-07-16 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > One thing that *would* be worth doing is merging upstream's recent > updates; for all I know they've already dealt with this. According > to the README, we last synced with the 2010c tzcode release, so we're > short a few years worth of upstream bug fixes t

Re: [HACKERS] Question about src/timezone/zic.c

2014-07-16 Thread Tom Lane
John Cochran writes: > [ useless code in zic.c ] I agree with you that that function looks pretty pointless, but here's the thing: that's not our code. Most of the code in src/timezone is taken directly from the IANA tzcode distribution (see src/timezone/README), and we're not very interested in

[HACKERS] Question about src/timezone/zic.c

2014-07-16 Thread John Cochran
I've recently found some time on my hands and have decided to see about contributing to the PostgreSQL project, so I've started browsing the code to get somewhat familiar with it. The file src/timezone/zic.c caused me to raise my eyebrows a bit and I have a question to ask because of this. I firs