Re: [HACKERS] REINDEX checking of index constraints

2013-07-22 Thread Alvaro Herrera
Noah Misch wrote: > I meant to ask whether, instead of reverting the accidental behavior change, > we should do something like leave the behavior and change the documentation > instead. I personally vote "no", but that alternative seemed credible enough > to justify mentioning it. Something more

Re: [HACKERS] REINDEX checking of index constraints

2013-07-22 Thread Noah Misch
On Sun, Jul 21, 2013 at 01:47:00PM -0700, Josh Berkus wrote: > On 07/21/2013 11:30 AM, Josh Berkus wrote: > >> Attached patch just restores the old behavior. Would it be worth > >> preserving > >> the ability to fix an index consistency problem with a REINDEX independent > >> from related heap co

Re: [HACKERS] REINDEX checking of index constraints

2013-07-22 Thread k...@rice.edu
On Sun, Jul 21, 2013 at 11:30:54AM -0700, Josh Berkus wrote: > Noah, > > > Attached patch just restores the old behavior. Would it be worth preserving > > the ability to fix an index consistency problem with a REINDEX independent > > from related heap consistency problems such as duplicate keys?

Re: [HACKERS] REINDEX checking of index constraints

2013-07-21 Thread Josh Berkus
On 07/21/2013 11:30 AM, Josh Berkus wrote: > Noah, > >> Attached patch just restores the old behavior. Would it be worth preserving >> the ability to fix an index consistency problem with a REINDEX independent >> from related heap consistency problems such as duplicate keys? > > I would love to

Re: [HACKERS] REINDEX checking of index constraints

2013-07-21 Thread Josh Berkus
On 07/21/2013 11:30 AM, Josh Berkus wrote: > Noah, > >> Attached patch just restores the old behavior. Would it be worth preserving >> the ability to fix an index consistency problem with a REINDEX independent >> from related heap consistency problems such as duplicate keys? > > I would love to

Re: [HACKERS] REINDEX checking of index constraints

2013-07-21 Thread Josh Berkus
Noah, > Attached patch just restores the old behavior. Would it be worth preserving > the ability to fix an index consistency problem with a REINDEX independent > from related heap consistency problems such as duplicate keys? I would love to have two versions of REINDEX, one which validated and

[HACKERS] REINDEX checking of index constraints

2013-07-21 Thread Noah Misch
Historically, REINDEX would always revalidate any uniqueness enforced by the index. An EDB customer reported that this is not happening, and indeed I broke it way back in commit 8ceb24568054232696dddc1166a8563bc78c900a. Specifically, REINDEX TABLE and REINDEX DATABASE no longer revalidate constrai