Re: [HACKERS] RLS related docs

2016-12-22 Thread Joe Conway
On 09/15/2016 02:34 PM, Joe Conway wrote: > On 09/15/2016 01:33 PM, Robert Haas wrote: >> On Sun, Aug 28, 2016 at 4:23 PM, Joe Conway wrote: > For COPY, I think perhaps it would be more logical to put the new note > immediately after the third note which describes the privileges > requ

Re: [HACKERS] RLS related docs

2016-09-15 Thread Joe Conway
On 09/15/2016 01:33 PM, Robert Haas wrote: > On Sun, Aug 28, 2016 at 4:23 PM, Joe Conway wrote: For COPY, I think perhaps it would be more logical to put the new note immediately after the third note which describes the privileges required, since it's kind of related, and then we ca

Re: [HACKERS] RLS related docs

2016-09-15 Thread Robert Haas
On Sun, Aug 28, 2016 at 4:23 PM, Joe Conway wrote: >>> For COPY, I think perhaps it would be more logical to put the new note >>> immediately after the third note which describes the privileges >>> required, since it's kind of related, and then we can talk about the >>> RLS policies required, e.g.

Re: [HACKERS] RLS related docs

2016-09-15 Thread Robert Haas
On Tue, Aug 30, 2016 at 3:05 AM, Dean Rasheed wrote: > On 28 August 2016 at 21:23, Joe Conway wrote: >> Apologies for the delay, but new patch attached. Assuming no more >> comments, will commit this, backpatched to 9.5, in a day or two. > > Looking at this again, I think there is something fishy

Re: [HACKERS] RLS related docs

2016-08-30 Thread Dean Rasheed
On 28 August 2016 at 21:23, Joe Conway wrote: > Apologies for the delay, but new patch attached. Assuming no more > comments, will commit this, backpatched to 9.5, in a day or two. > Looking at this again, I think there is something fishy about these dump/restore flags. If you do pg_dump --enabl

Re: [HACKERS] RLS related docs

2016-08-28 Thread Joe Conway
On 05/30/2016 01:56 PM, Joe Conway wrote: > On 05/26/2016 12:26 AM, Dean Rasheed wrote: >> On 25 May 2016 at 02:04, Joe Conway wrote: >>> Please see attached two proposed patches for the docs related to RLS: >>> >>> 1) Correction to pg_restore >>> 2) Additional mentions that "COPY FROM" does not a

Re: [HACKERS] RLS related docs

2016-05-30 Thread Joe Conway
On 05/26/2016 12:26 AM, Dean Rasheed wrote: > On 25 May 2016 at 02:04, Joe Conway wrote: >> Please see attached two proposed patches for the docs related to RLS: >> >> 1) Correction to pg_restore >> 2) Additional mentions that "COPY FROM" does not allow RLS to be enabled >> >> Comments? >> > > Th

Re: [HACKERS] RLS related docs

2016-05-26 Thread Dean Rasheed
On 25 May 2016 at 02:04, Joe Conway wrote: > Please see attached two proposed patches for the docs related to RLS: > > 1) Correction to pg_restore > 2) Additional mentions that "COPY FROM" does not allow RLS to be enabled > > Comments? > The pg_restore change looks good -- that was clearly wrong.

[HACKERS] RLS related docs

2016-05-24 Thread Joe Conway
Please see attached two proposed patches for the docs related to RLS: 1) Correction to pg_restore 2) Additional mentions that "COPY FROM" does not allow RLS to be enabled Comments? Related question: I believe COPY tbl TO ... is internally converted to COPY (select * FROM tbl) TO ... when