On Thu, Feb 10, 2011 at 1:23 PM, Heikki Linnakangas
wrote:
> On 10.02.2011 20:01, Peter Eisentraut wrote:
>>
>> On tor, 2011-02-10 at 09:28 -0800, Jeff Davis wrote:
>>>
>>> I originally put it there so that I wouldn't mix up data directories
>>> with a patch I'm reviewing, but I agree that it seem
On 10.02.2011 20:01, Peter Eisentraut wrote:
On tor, 2011-02-10 at 09:28 -0800, Jeff Davis wrote:
I originally put it there so that I wouldn't mix up data directories
with a patch I'm reviewing, but I agree that it seems easier this way.
FWIW, I disagree with Tom and do recommend putting the c
On Thu, 2011-02-10 at 15:38 +0100, Erik Rijkers wrote:
> I've removed the change to catversion.h (18 lines, starting at 4985) from the
> patch file; then it
> applies cleanly.
I should mention that the last patch changed the representation to be
more compact. So, if you have any existing test dat
On tor, 2011-02-10 at 09:28 -0800, Jeff Davis wrote:
> I originally put it there so that I wouldn't mix up data directories
> with a patch I'm reviewing, but I agree that it seems easier this way.
FWIW, I disagree with Tom and do recommend putting the catversion change
in the patch.
--
Sent via
On Thu, 2011-02-10 at 12:04 -0500, Tom Lane wrote:
> "Erik Rijkers" writes:
> > On Wed, February 9, 2011 09:35, Jeff Davis wrote:
> >> Updated patch.
>
> > I just wanted to mention that this latest patch doesn't quite apply as-is,
> > because of catversion changes.
>
> Just a note: standard pra
"Erik Rijkers" writes:
> On Wed, February 9, 2011 09:35, Jeff Davis wrote:
>> Updated patch.
> I just wanted to mention that this latest patch doesn't quite apply as-is,
> because of catversion changes.
Just a note: standard practice is for submitted patches to *not* touch
catversion.h. The co
On Wed, February 9, 2011 09:35, Jeff Davis wrote:
> Updated patch.
>
Thanks!
I just wanted to mention that this latest patch doesn't quite apply as-is,
because of catversion
changes.
I've removed the change to catversion.h (18 lines, starting at 4985) from the
patch file; then it
applies clean