Re: [HACKERS] Re: [BUGS] BUG #14350: VIEW with INSTEAD OF INSERT TRIGGER and COPY. Missing feature or working as designed.

2016-11-10 Thread Haribabu Kommi
On Fri, Nov 11, 2016 at 6:15 AM, Tom Lane wrote: > Haribabu Kommi writes: > > [ copy_to_view_3.patch ] > > Pushed with cosmetic adjustments. > Thank you. Regards, Hari Babu Fujitsu Australia

Re: [HACKERS] Re: [BUGS] BUG #14350: VIEW with INSTEAD OF INSERT TRIGGER and COPY. Missing feature or working as designed.

2016-11-10 Thread Tom Lane
Haribabu Kommi writes: > [ copy_to_view_3.patch ] Pushed with cosmetic adjustments. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Re: [BUGS] BUG #14350: VIEW with INSTEAD OF INSERT TRIGGER and COPY. Missing feature or working as designed.

2016-11-07 Thread Dilip Kumar
On Fri, Nov 4, 2016 at 7:14 AM, Haribabu Kommi wrote: >> + if (cstate->rel->rd_rel->relkind != RELKIND_RELATION >> + && (!cstate->rel->trigdesc || >> + !cstate->rel->trigdesc->trig_insert_instead_row)) > > > changed. > >> >> Meanwhile I will test it and give the feedback. > > > Thanks. > > Updated

[HACKERS] Re: [BUGS] BUG #14350: VIEW with INSTEAD OF INSERT TRIGGER and COPY. Missing feature or working as designed.

2016-11-03 Thread Haribabu Kommi
On Thu, Nov 3, 2016 at 5:23 PM, Dilip Kumar wrote: > On Thu, Nov 3, 2016 at 9:57 AM, Haribabu Kommi > wrote: > > Thanks for your suggestion. Yes, I agree that adding a hint is good. > > Updated patch is attached with addition of hint message. > > > > 2016-11-03 14:56:28.685 AEDT [7822] ERROR: c

[HACKERS] Re: [BUGS] BUG #14350: VIEW with INSTEAD OF INSERT TRIGGER and COPY. Missing feature or working as designed.

2016-11-02 Thread Dilip Kumar
On Thu, Nov 3, 2016 at 9:57 AM, Haribabu Kommi wrote: > Thanks for your suggestion. Yes, I agree that adding a hint is good. > Updated patch is attached with addition of hint message. > > 2016-11-03 14:56:28.685 AEDT [7822] ERROR: cannot copy to view "ttt_v" > 2016-11-03 14:56:28.685 AEDT [7822]

[HACKERS] Re: [BUGS] BUG #14350: VIEW with INSTEAD OF INSERT TRIGGER and COPY. Missing feature or working as designed.

2016-11-02 Thread Haribabu Kommi
On Tue, Nov 1, 2016 at 8:05 PM, Dilip Kumar wrote: > On Tue, Nov 1, 2016 at 12:40 PM, Haribabu Kommi > wrote: > > COPY command is treated as an UTILITY command, During the query > > processing, the rules are not applied on the COPY command, and in the > > execution of COPY command, it just inser

[HACKERS] Re: [BUGS] BUG #14350: VIEW with INSTEAD OF INSERT TRIGGER and COPY. Missing feature or working as designed.

2016-11-01 Thread Dilip Kumar
On Tue, Nov 1, 2016 at 12:40 PM, Haribabu Kommi wrote: > COPY command is treated as an UTILITY command, During the query > processing, the rules are not applied on the COPY command, and in the > execution of COPY command, it just inserts the data into the heap and > indexes with direct calls. > >

[HACKERS] Re: [BUGS] BUG #14350: VIEW with INSTEAD OF INSERT TRIGGER and COPY. Missing feature or working as designed.

2016-11-01 Thread Haribabu Kommi
On Tue, Nov 1, 2016 at 3:54 PM, Dilip Kumar wrote: > On Tue, Oct 4, 2016 at 1:07 PM, Haribabu Kommi > wrote: > > I think currently there is no handling of INSTEAD of triggers in the copy > > functionality. > > > > It didn't seem difficult to the support the same, until unless there are > any > >