Re: [HACKERS] Re: [BUGS] BUG #4027: backslash escapingnotdisabled inplpgsql

2009-04-10 Thread Tom Lane
Andrew Gierth writes: > "Tom" == Tom Lane writes: > Tom> Back to the point at hand: do we want to look at making plpgsql > Tom> respect the GUC? > Surely what matters is the value of the GUC at the time that you did > the CREATE FUNCTION, not the value at the time you happen to be > calling it

Re: [HACKERS] Re: [BUGS] BUG #4027: backslash escapingnotdisabled inplpgsql

2009-04-10 Thread Andrew Gierth
> "Tom" == Tom Lane writes: Tom> Back to the point at hand: do we want to look at making plpgsql Tom> respect the GUC? Surely what matters is the value of the GUC at the time that you did the CREATE FUNCTION, not the value at the time you happen to be calling it? -- Andrew (irc:RhodiumTo

Re: [HACKERS] Re: [BUGS] BUG #4027: backslash escapingnotdisabled inplpgsql

2009-04-10 Thread Kevin Grittner
Tom Lane wrote: > do we want to look at making plpgsql respect the GUC? +1 > I'm inclined to deal with the special case (RAISE and anything else > similar) by changing the code so that we *do* feed the string > literal through the main parser, not for any functional effect but > just to have

Re: [HACKERS] Re: [BUGS] BUG #4027: backslash escapingnotdisabled inplpgsql

2009-04-10 Thread Tom Lane
Bruce Momjian writes: > Kevin Grittner wrote: >> My personal bias is to go to the standard behavior as the default at >> some point. For legacy reasons, I don't know that you would ever want >> to remove the setting; especially since I don't think it adds much >> code if you're going to support t

Re: [HACKERS] Re: [BUGS] BUG #4027: backslash escapingnotdisabled inplpgsql

2009-04-10 Thread Bruce Momjian
Kevin Grittner wrote: > Bruce Momjian wrote: > > It would be nice to know if we are ever going to set > > standard_conforming_strings to on. > > My personal bias is to go to the standard behavior as the default at > some point. For legacy reasons, I don't know that you would ever want > to remo

Re: [HACKERS] Re: [BUGS] BUG #4027: backslash escapingnotdisabled inplpgsql

2009-04-10 Thread Kevin Grittner
Bruce Momjian wrote: > It would be nice to know if we are ever going to set > standard_conforming_strings to on. My personal bias is to go to the standard behavior as the default at some point. For legacy reasons, I don't know that you would ever want to remove the setting; especially since I d

Re: [HACKERS] Re: [BUGS] BUG #4027: backslash escapingnotdisabled inplpgsql

2009-04-09 Thread Kevin Grittner
I wrote: > Tom Lane wrote: >> I think you are confusing parsing of the string literal that >> is the argument of CREATE FUNCTION with the parsing that the plpgsql >> interpreter does on the function body once it gets it. > Oh, I'm not confused about that at all. I'm arguing that it's a bad >