Re: [HACKERS] Re: [BUGS] libpq does not manage SSL callbacks properly when other libraries are involved.

2008-12-03 Thread Magnus Hagander
Magnus Hagander wrote: > Bruce Momjian wrote: >> Bruce Momjian wrote: >>> Thanks for the review, Magnus. I have adjusted the patch to use the >>> same mutex every time the counter is accessed, and adjusted the >>> pqsecure_destroy() call to properly decrement in the right place. >>> >>> Also, I re

Re: [HACKERS] Re: [BUGS] libpq does not manage SSL callbacks properly when other libraries are involved.

2008-12-03 Thread Magnus Hagander
Bruce Momjian wrote: > Bruce Momjian wrote: >> Thanks for the review, Magnus. I have adjusted the patch to use the >> same mutex every time the counter is accessed, and adjusted the >> pqsecure_destroy() call to properly decrement in the right place. >> >> Also, I renamed the libpq global destroy

Re: [HACKERS] Re: [BUGS] libpq does not manage SSL callbacks properly when other libraries are involved.

2008-11-20 Thread Bruce Momjian
Bruce Momjian wrote: > Thanks for the review, Magnus. I have adjusted the patch to use the > same mutex every time the counter is accessed, and adjusted the > pqsecure_destroy() call to properly decrement in the right place. > > Also, I renamed the libpq global destroy function to be clearer > (t

Re: [HACKERS] Re: [BUGS] libpq does not manage SSL callbacks properly when other libraries are involved.

2008-11-19 Thread Bruce Momjian
Russell Smith wrote: > Tom Lane wrote: > > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > > >> Bruce Momjian wrote: > >> > >>> This is not something we would typically backpatch because of the danger > >>> of introducing some unexpected change in libpq. We can provide a patch > >>> to anyo

Re: [HACKERS] Re: [BUGS] libpq does not manage SSL callbacks properly when other libraries are involved.

2008-11-19 Thread Russell Smith
Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > >> Bruce Momjian wrote: >> >>> This is not something we would typically backpatch because of the danger >>> of introducing some unexpected change in libpq. We can provide a patch >>> to anyone who needs it, or if the community

Re: [HACKERS] Re: [BUGS] libpq does not manage SSL callbacks properly when other libraries are involved.

2008-11-18 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Bruce Momjian wrote: >> This is not something we would typically backpatch because of the danger >> of introducing some unexpected change in libpq. We can provide a patch >> to anyone who needs it, or if the community wants it backpatched I can >> certa

Re: [HACKERS] Re: [BUGS] libpq does not manage SSL callbacks properly when other libraries are involved.

2008-11-18 Thread Alvaro Herrera
Bruce Momjian wrote: > Russell Smith wrote: > > Will this be back patched when it's committed? > > This is not something we would typically backpatch because of the danger > of introducing some unexpected change in libpq. We can provide a patch > to anyone who needs it, or if the community wants

Re: [HACKERS] Re: [BUGS] libpq does not manage SSL callbacks properly when other libraries are involved.

2008-11-17 Thread Bruce Momjian
Russell Smith wrote: > Bruce Momjian wrote: > > Yes, my defines were very messed up; updated version attached. > > > Hi, > > I've not done a review of this patch, however I did backport it to 8.3 > (as attached in unified diff). The patch wasn't made for PG purposes, so > it's not in context d

Re: [HACKERS] Re: [BUGS] libpq does not manage SSL callbacks properly when other libraries are involved.

2008-11-13 Thread Russell Smith
Bruce Momjian wrote: > Yes, my defines were very messed up; updated version attached. > Hi, I've not done a review of this patch, however I did backport it to 8.3 (as attached in unified diff). The patch wasn't made for PG purposes, so it's not in context diff. I tested the backported patch an

Re: [HACKERS] Re: [BUGS] libpq does not manage SSL callbacks properly when other libraries are involved.

2008-11-07 Thread Bruce Momjian
Alvaro Herrera wrote: > Bruce Momjian wrote: > > > Thanks for the review, Magnus. I have adjusted the patch to use the > > same mutex every time the counter is accessed, and adjusted the > > pqsecure_destroy() call to properly decrement in the right place. > > > > Also, I renamed the libpq globa

Re: [HACKERS] Re: [BUGS] libpq does not manage SSL callbacks properly when other libraries are involved.

2008-11-07 Thread Alvaro Herrera
Bruce Momjian wrote: > Thanks for the review, Magnus. I have adjusted the patch to use the > same mutex every time the counter is accessed, and adjusted the > pqsecure_destroy() call to properly decrement in the right place. > > Also, I renamed the libpq global destroy function to be clearer > (

Re: [HACKERS] Re: [BUGS] libpq does not manage SSL callbacks properly when other libraries are involved.

2008-11-04 Thread Bruce Momjian
Magnus Hagander wrote: > > Your analysis of this problem is right on target. When the SSL > > callbacks were implemented for threaded libpq, there was never any > > thought on the effect of unloading libpq while the callbacks were still > > registered. > > > > The attached patch unregisters the c

Re: [HACKERS] Re: [BUGS] libpq does not manage SSL callbacks properly when other libraries are involved.

2008-11-03 Thread Magnus Hagander
Bruce Momjian wrote: > Russell Smith wrote: >> Alvaro Herrera wrote: >>> PoolSnoopy wrote: >>> ***PUSH*** this bug is really some annoyance if you use automatic build environments. I'm using phpunit to run tests and as soon as postgres is involved the php cli environment

[HACKERS] Re: [BUGS] libpq does not manage SSL callbacks properly when other libraries are involved.

2008-10-27 Thread Bruce Momjian
Russell Smith wrote: > Alvaro Herrera wrote: > > PoolSnoopy wrote: > > > >> ***PUSH*** > >> > >> this bug is really some annoyance if you use automatic build environments. > >> I'm using phpunit to run tests and as soon as postgres is involved the php > >> cli environment segfaults at the end. t