Re: [HACKERS] Re: [COMMITTERS] pgsql: Disable -faggressive-loop-optimizations in gcc 4.8+ for pre-9.2

2015-01-21 Thread Alvaro Herrera
Bernd Helmle wrote: > > > --On 20. Januar 2015 17:15:01 +0100 Andres Freund > wrote: > > >I personally think that being able to at least compile/make check old > >versions a bit longer is a good idea. > > +1 from me for this idea. Already done yesterday :-) Thanks, -- Álvaro Herrera

Re: [HACKERS] Re: [COMMITTERS] pgsql: Disable -faggressive-loop-optimizations in gcc 4.8+ for pre-9.2

2015-01-21 Thread Bernd Helmle
--On 20. Januar 2015 17:15:01 +0100 Andres Freund wrote: I personally think that being able to at least compile/make check old versions a bit longer is a good idea. +1 from me for this idea. -- Thanks Bernd -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)

Re: [HACKERS] Re: [COMMITTERS] pgsql: Disable -faggressive-loop-optimizations in gcc 4.8+ for pre-9.2

2015-01-20 Thread Robert Haas
On Tue, Jan 20, 2015 at 11:18 AM, Alvaro Herrera wrote: > Robert Haas wrote: >> > Would anybody object to me pushing this commit to branches 8.2 and 8.3? >> >> Since those branches are out of support, I am not sure what the point >> is. If we want people to be able to use those branches reasonabl

Re: [HACKERS] Re: [COMMITTERS] pgsql: Disable -faggressive-loop-optimizations in gcc 4.8+ for pre-9.2

2015-01-20 Thread Alvaro Herrera
Robert Haas wrote: > > Would anybody object to me pushing this commit to branches 8.2 and 8.3? > > Since those branches are out of support, I am not sure what the point > is. If we want people to be able to use those branches reasonably we > need to back-port fixes for critical security and stab

Re: [HACKERS] Re: [COMMITTERS] pgsql: Disable -faggressive-loop-optimizations in gcc 4.8+ for pre-9.2

2015-01-20 Thread Andres Freund
On 2015-01-20 11:10:53 -0500, Robert Haas wrote: > On Tue, Jan 20, 2015 at 10:30 AM, Alvaro Herrera > wrote: > > Tom Lane wrote: > >> Disable -faggressive-loop-optimizations in gcc 4.8+ for pre-9.2 branches. > >> With this optimization flag enabled, recent versions of gcc can generate > >> incorre

Re: [HACKERS] Re: [COMMITTERS] pgsql: Disable -faggressive-loop-optimizations in gcc 4.8+ for pre-9.2

2015-01-20 Thread Robert Haas
On Tue, Jan 20, 2015 at 10:30 AM, Alvaro Herrera wrote: > Tom Lane wrote: >> Disable -faggressive-loop-optimizations in gcc 4.8+ for pre-9.2 branches. >> With this optimization flag enabled, recent versions of gcc can generate >> incorrect code that assumes variable-length arrays (such as oidvecto

[HACKERS] Re: [COMMITTERS] pgsql: Disable -faggressive-loop-optimizations in gcc 4.8+ for pre-9.2

2015-01-20 Thread Alvaro Herrera
Tom Lane wrote: > Disable -faggressive-loop-optimizations in gcc 4.8+ for pre-9.2 branches. > > With this optimization flag enabled, recent versions of gcc can generate > incorrect code that assumes variable-length arrays (such as oidvector) > are actually fixed-length because they're embedded in