Re: [HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2009-01-22 Thread Magnus Hagander
Hiroshi Inoue wrote: > Magnus Hagander wrote: >> Peter Eisentraut wrote: >>> Magnus Hagander wrote: However, one question: The comment currently says it's harmless to do this on non-windows platforms. Does this still hold true? >>> Yes, the non-WIN32 code path appears to be the same, stil

Re: [HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2009-01-22 Thread Hiroshi Inoue
Magnus Hagander wrote: Peter Eisentraut wrote: Magnus Hagander wrote: However, one question: The comment currently says it's harmless to do this on non-windows platforms. Does this still hold true? Yes, the non-WIN32 code path appears to be the same, still. But the ifdef WIN32 part we don't w

Re: [HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2009-01-21 Thread Peter Eisentraut
Magnus Hagander wrote: Peter Eisentraut wrote: Magnus Hagander wrote: However, one question: The comment currently says it's harmless to do this on non-windows platforms. Does this still hold true? Yes, the non-WIN32 code path appears to be the same, still. But the ifdef WIN32 part we don't w

Re: [HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2009-01-21 Thread Magnus Hagander
Peter Eisentraut wrote: > Magnus Hagander wrote: >> However, one question: The comment currently says it's harmless to do >> this on non-windows platforms. Does this still hold true? > > Yes, the non-WIN32 code path appears to be the same, still. But the > ifdef WIN32 part we don't want, because

Re: [HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2009-01-21 Thread Peter Eisentraut
Magnus Hagander wrote: However, one question: The comment currently says it's harmless to do this on non-windows platforms. Does this still hold true? Yes, the non-WIN32 code path appears to be the same, still. But the ifdef WIN32 part we don't want, because that presumes something about the

Re: [HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2009-01-21 Thread Magnus Hagander
Hiroshi Inoue wrote: > Hiroshi Inoue wrote: >> Magnus Hagander wrote: >>> Hiroshi Inoue wrote: Hiroshi Inoue wrote: > Bruce Momjian wrote: >> Hiroshi, is this patch still needed? > Yes though it should be slightly changed now. >>> >>> In what way should it be changed? >> >> One is

Re: [HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2009-01-20 Thread Hiroshi Inoue
Hiroshi Inoue wrote: Magnus Hagander wrote: Hiroshi Inoue wrote: Hiroshi Inoue wrote: Bruce Momjian wrote: Hiroshi, is this patch still needed? Yes though it should be slightly changed now. In what way should it be changed? One is already committed by you. [COMMITTERS] pgsql: Use the ne

Re: [HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2009-01-19 Thread Hiroshi Inoue
Magnus Hagander wrote: Hiroshi Inoue wrote: Hiroshi Inoue wrote: Bruce Momjian wrote: Hiroshi, is this patch still needed? Yes though it should be slightly changed now. In what way should it be changed? One is already committed by you. [COMMITTERS] pgsql: Use the new text domain names A

Re: [HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2009-01-19 Thread Magnus Hagander
Hiroshi Inoue wrote: > Hiroshi Inoue wrote: >> Bruce Momjian wrote: >>> Hiroshi, is this patch still needed? >> >> Yes though it should be slightly changed now. In what way should it be changed? //Magnus -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to y

Re: [HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2009-01-11 Thread Hiroshi Inoue
Hiroshi Inoue wrote: Bruce Momjian wrote: Hiroshi, is this patch still needed? Yes though it should be slightly changed now. *set lc_messages does not work* issue isn't directly related to this issue. Though I'm not sure how we can test it, I can provide test results like the attached one.

Re: [HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2009-01-10 Thread Hiroshi Saito
Hi. My swift attack test was the MinGW environment. But, Inoue-san suggestion. 1. MinGW+gcc build HIROSHI=# set LC_TIME=Ja; SET HIROSHI=# select to_char(now(),'TMDay'); to_char - 日曜日 (1 行) HIROSHI=# set LC_TIME='Japan'; SET HIROSHI=# select to_char(Now(),'TMDay'); to_char - 日曜日 (

Re: [HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2009-01-09 Thread Hiroshi Inoue
Bruce Momjian wrote: Hiroshi, is this patch still needed? Yes though it should be slightly changed now. *set lc_messages does not work* issue isn't directly related to this issue. regards, Hiroshi Inoue -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to

Re: [HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2009-01-09 Thread Tom Lane
Bruce Momjian writes: > Hiroshi, is this patch still needed? This patch is for a problem that's entirely separate from the LC_TIME issue, if that's what you were wondering. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make c

Re: [HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2009-01-09 Thread Bruce Momjian
Hiroshi, is this patch still needed? --- Hiroshi Inoue wrote: > Magnus Hagander wrote: > > On 25 nov 2008, at 05.00, Tom Lane wrote: > > > >> Hiroshi Inoue writes: > >>> Tom Lane wrote: > If that's true then this cod

Re: [HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2008-12-03 Thread Hiroshi Inoue
Magnus Hagander wrote: Hiroshi Inoue wrote: I think the thing us that as long as the encodings are compatible (latin1 with different names for example) it worked fine. In any case I think the problem is that gettext is looking at a setting that is not what we are looking at. Particularly wi

Re: [HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2008-12-03 Thread Magnus Hagander
Hiroshi Inoue wrote: >> I think the thing us that as long as the encodings are compatible >> (latin1 with different names for example) it worked fine. >> >>> In any case I think the problem is that gettext is >>> looking at a setting that is not what we are looking at. Particularly >>> with the

Re: [HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2008-11-27 Thread Hiroshi Inoue
Magnus Hagander wrote: On 25 nov 2008, at 05.00, Tom Lane <[EMAIL PROTECTED]> wrote: Hiroshi Inoue <[EMAIL PROTECTED]> writes: Tom Lane wrote: If that's true then this code is presently broken for *every* locale under Windows, not only Japanese. Maybe there are a few languages/countires wh

Re: [HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2008-11-24 Thread Magnus Hagander
On 25 nov 2008, at 05.00, Tom Lane <[EMAIL PROTECTED]> wrote: Hiroshi Inoue <[EMAIL PROTECTED]> writes: Tom Lane wrote: If that's true then this code is presently broken for *every* locale under Windows, not only Japanese. Maybe there are a few languages/countires where 2 encodings are wide

Re: [HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2008-11-24 Thread Tom Lane
Hiroshi Inoue <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> If that's true then this code is presently broken for *every* locale >> under Windows, not only Japanese. > Maybe there are a few languages/countires where 2 encodings are > widely used. UTF8 vs Latin-N? In any case I think the prob

Re: [HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2008-11-24 Thread Hiroshi Inoue
Tom Lane wrote: > Hiroshi Inoue <[EMAIL PROTECTED]> writes: >> Tom Lane wrote: >>> I'm not following this either. If the patch is really necessary then it >>> seems it must be working around a bug in the Windows version of gettext, >>> ie failure to distinguish CP932 from CP20932. Is that correct

Re: [HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2008-11-24 Thread Tom Lane
Hiroshi Inoue <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> I'm not following this either. If the patch is really necessary then it >> seems it must be working around a bug in the Windows version of gettext, >> ie failure to distinguish CP932 from CP20932. Is that correct? > I'm afraid I don'

Re: [HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2008-11-24 Thread Hiroshi Inoue
Tom Lane wrote: > Magnus Hagander <[EMAIL PROTECTED]> writes: >> Hiroshi Inoue wrote: >>> because Shift_JIS isn't allowed as a server encoding. So >>> the Japanese Windows native message encoding Shift_JIS never >>> matches the server encoding EUC_JP and a conversion between >>> Shitt_jis and EUC_J

Re: [HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2008-11-24 Thread Tom Lane
Magnus Hagander <[EMAIL PROTECTED]> writes: > Hiroshi Inoue wrote: >> because Shift_JIS isn't allowed as a server encoding. So >> the Japanese Windows native message encoding Shift_JIS never >> matches the server encoding EUC_JP and a conversion between >> Shitt_jis and EUC_JP is necessarily needed

[HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2008-11-24 Thread Magnus Hagander
Hiroshi Inoue wrote: > Magnus Hagander wrote: >> Hiroshi Inoue wrote: >>> Hi Magnus and all, >>> >>> Magnus Hagander wrote: Log Message: --- Explicitly bind gettext() to the UTF8 locale when in use. This is required on Windows due to the special locale handling for

[HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2008-11-24 Thread Hiroshi Inoue
Magnus Hagander wrote: > Hiroshi Inoue wrote: >> Hi Magnus and all, >> >> Magnus Hagander wrote: >>> Log Message: >>> --- >>> Explicitly bind gettext() to the UTF8 locale when in use. >>> This is required on Windows due to the special locale >>> handling for UTF8 that doesn't change the fu

[HACKERS] Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

2008-11-24 Thread Magnus Hagander
Hiroshi Inoue wrote: > Hi Magnus and all, > > Magnus Hagander wrote: >> Log Message: >> --- >> Explicitly bind gettext() to the UTF8 locale when in use. >> This is required on Windows due to the special locale >> handling for UTF8 that doesn't change the full environment. > > Thanks to t