[HACKERS] Re: [COMMITTERS] pgsql: Fix and simplify check for whether we're running as Windows serv

2017-03-24 Thread Dave Page
On Friday, March 24, 2017, Heikki Linnakangas wrote: > On 03/22/2017 07:44 PM, Robert Haas wrote: > >> On Wed, Mar 22, 2017 at 10:13 AM, Alvaro Herrera >> wrote: >> >>> Heikki Linnakangas wrote: >>> I did some archeology, and found CheckTokenMembership() in MinGW's w32api packages

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix and simplify check for whether we're running as Windows serv

2017-03-24 Thread Heikki Linnakangas
On 03/22/2017 07:44 PM, Robert Haas wrote: On Wed, Mar 22, 2017 at 10:13 AM, Alvaro Herrera wrote: Heikki Linnakangas wrote: I did some archeology, and found CheckTokenMembership() in MinGW's w32api packages version 3.14 (https://sourceforge.net/projects/mingw/files/MinGW/Base/w32api/w32api-3.

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix and simplify check for whether we're running as Windows serv

2017-03-22 Thread Robert Haas
On Wed, Mar 22, 2017 at 10:13 AM, Alvaro Herrera wrote: > Heikki Linnakangas wrote: >> I did some archeology, and found CheckTokenMembership() in MinGW's w32api >> packages version 3.14 >> (https://sourceforge.net/projects/mingw/files/MinGW/Base/w32api/w32api-3.14/, >> in include/winbase.h). Accor

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix and simplify check for whether we're running as Windows serv

2017-03-22 Thread Alvaro Herrera
Heikki Linnakangas wrote: > I did some archeology, and found CheckTokenMembership() in MinGW's w32api > packages version 3.14 > (https://sourceforge.net/projects/mingw/files/MinGW/Base/w32api/w32api-3.14/, > in include/winbase.h). According to the timestamps on that download page, > that was relea

[HACKERS] Re: [COMMITTERS] pgsql: Fix and simplify check for whether we're running as Windows serv

2017-03-22 Thread Heikki Linnakangas
On 03/19/2017 11:40 PM, Tom Lane wrote: Heikki Linnakangas writes: On 03/17/2017 07:57 PM, Tom Lane wrote: This seems to have broken narwhal: It's not very nice to change the requirements in a minor version, but I don't think this would be a real problem for anyone. Not many people build Po

[HACKERS] Re: [COMMITTERS] pgsql: Fix and simplify check for whether we're running as Windows serv

2017-03-19 Thread Heikki Linnakangas
On 03/17/2017 07:57 PM, Tom Lane wrote: Heikki Linnakangas writes: Fix and simplify check for whether we're running as Windows service. This seems to have broken narwhal: Creating library file: libpostgres.a ../../src/port/libpgport_srv.a(win32security_srv.o)(.text+0x109): In function `pgwi