[HACKERS] Re: [COMMITTERS] pgsql: GIN index build's allocatedMemory counter needs to be long, not

2007-11-18 Thread Jeremy Drake
On Fri, 16 Nov 2007, Tom Lane wrote: GIN index build's allocatedMemory counter needs to be long, not uint32. Else, in a 64-bit machine with maintenance_work_mem set to above 4Gb, the counter overflows I don't know if this has been discussed before, but you are aware that it is not dictated by

Re: [HACKERS] Re: [COMMITTERS] pgsql: GIN index build's allocatedMemory counter needs to be long, not

2007-11-18 Thread Peter Eisentraut
Jeremy Drake wrote: I don't know if this has been discussed before, but you are aware that it is not dictated by the C standard that sizeof(long) == sizeof(void*)? As evidenced by this piece of code in postgres.h: typedef unsigned long Datum;/* XXX sizeof(long) = sizeof(void *) */ The

Re: [HACKERS] Re: [COMMITTERS] pgsql: GIN index build's allocatedMemory counter needs to be long, not

2007-11-18 Thread Tom Lane
Peter Eisentraut [EMAIL PROTECTED] writes: Jeremy Drake wrote: I don't know if this has been discussed before, but you are aware that it is not dictated by the C standard that sizeof(long) == sizeof(void*)? Yes, and there is lots of work left to do to support that. Yeah. The current code