Re: [HACKERS] Re: [COMMITTERS] pgsql: Get rid of the global variable holding the error state

2011-01-29 Thread Peter Eisentraut
On tor, 2011-01-27 at 00:25 +0100, Jan Urbański wrote: > _2 is only Python 2.2, but I tried: with Python 2.2 there's a whole > lot of regression tests that fail. The last release of 2.2 is April > 2003, maybe it's time to forget about that particular dinosaur? I agree that we should remove the plp

Re: [HACKERS] Re: [COMMITTERS] pgsql: Get rid of the global variable holding the error state

2011-01-26 Thread Tom Lane
=?UTF-8?B?SmFuIFVyYmHFhHNraQ==?= writes: > _2 is only Python 2.2, but I tried: with Python 2.2 there's a whole lot > of regression tests that fail. The last release of 2.2 is April 2003, > maybe it's time to forget about that particular dinosaur? Well, there's little point in carrying an incorrec

Re: [HACKERS] Re: [COMMITTERS] pgsql: Get rid of the global variable holding the error state

2011-01-26 Thread Jan Urbański
On 27/01/11 00:15, Tom Lane wrote: > Peter Eisentraut writes: >> On ons, 2011-01-26 at 17:47 -0500, Tom Lane wrote: >>> I was a bit disturbed by the fact that fixing only one of the four >>> variant files was enough to turn the whole buildfarm green. Are the >>> other three cases even needed anym

Re: [HACKERS] Re: [COMMITTERS] pgsql: Get rid of the global variable holding the error state

2011-01-26 Thread Tom Lane
Peter Eisentraut writes: > On ons, 2011-01-26 at 17:47 -0500, Tom Lane wrote: >> I was a bit disturbed by the fact that fixing only one of the four >> variant files was enough to turn the whole buildfarm green. Are the >> other three cases even needed anymore? If so, how can we get some >> cover

Re: [HACKERS] Re: [COMMITTERS] pgsql: Get rid of the global variable holding the error state

2011-01-26 Thread Peter Eisentraut
On ons, 2011-01-26 at 17:47 -0500, Tom Lane wrote: > Peter Eisentraut writes: > > On lör, 2011-01-22 at 16:36 -0500, Tom Lane wrote: > >> Peter Eisentraut writes: > >>> Get rid of the global variable holding the error state > > >> The buildfarm doesn't like this patch one bit. > > > I have veri

Re: [HACKERS] Re: [COMMITTERS] pgsql: Get rid of the global variable holding the error state

2011-01-26 Thread Tom Lane
Peter Eisentraut writes: > On lör, 2011-01-22 at 16:36 -0500, Tom Lane wrote: >> Peter Eisentraut writes: >>> Get rid of the global variable holding the error state >> The buildfarm doesn't like this patch one bit. > I have verified your adjustments and fixed up the rest. I was a bit disturbe

[HACKERS] Re: [COMMITTERS] pgsql: Get rid of the global variable holding the error state

2011-01-26 Thread Peter Eisentraut
On lör, 2011-01-22 at 16:36 -0500, Tom Lane wrote: > Peter Eisentraut writes: > > Get rid of the global variable holding the error state > > The buildfarm doesn't like this patch one bit. I have verified your adjustments and fixed up the rest. -- Sent via pgsql-hackers mailing list (pgsql-hac