Re: [HACKERS] Re: [COMMITTERS] pgsql: On Windows, when a file is deleted and another process still has

2009-09-13 Thread Heikki Linnakangas
Tom Lane wrote: > Magnus Hagander writes: >> On Fri, Sep 11, 2009 at 10:44, Heikki Linnakangas >>> Here's a patch implementing that, and changing pgrename() to check for >>> ERROR_SHARING_VIOLATION and ERROR_LOCK_VIOLATION like pgwin32_open() >>> does, instead of ERROR_ACCESS_DENIED. > >> I have

Re: [HACKERS] Re: [COMMITTERS] pgsql: On Windows, when a file is deleted and another process still has

2009-09-11 Thread Tom Lane
Magnus Hagander writes: > On Fri, Sep 11, 2009 at 10:44, Heikki Linnakangas >> Here's a patch implementing that, and changing pgrename() to check for >> ERROR_SHARING_VIOLATION and ERROR_LOCK_VIOLATION like pgwin32_open() >> does, instead of ERROR_ACCESS_DENIED. > I have definitely seen AV progra

Re: [HACKERS] Re: [COMMITTERS] pgsql: On Windows, when a file is deleted and another process still has

2009-09-11 Thread Magnus Hagander
On Fri, Sep 11, 2009 at 10:44, Heikki Linnakangas wrote: > (moving to pgsql-hackers) > > Tom Lane wrote: >> Heikki Linnakangas writes: >>> A completely different approach would be to treat any failure on all >>> platforms as non-fatal. We shouldn't really cut the checkpoint short if >>> recycling

Re: [HACKERS] Re: [COMMITTERS] pgsql: On Windows, when a file is deleted and another process still has

2009-09-11 Thread Tom Lane
Heikki Linnakangas writes: > Here's a patch implementing that, and changing pgrename() to check for > ERROR_SHARING_VIOLATION and ERROR_LOCK_VIOLATION like pgwin32_open() > does, instead of ERROR_ACCESS_DENIED. This looks sane in a quick once-over, though I haven't tested it. One tiny stylistic s

[HACKERS] Re: [COMMITTERS] pgsql: On Windows, when a file is deleted and another process still has

2009-09-11 Thread Heikki Linnakangas
(moving to pgsql-hackers) Tom Lane wrote: > Heikki Linnakangas writes: >> A completely different approach would be to treat any failure on all >> platforms as non-fatal. We shouldn't really cut the checkpoint short if >> recycling a WAL file fails, whatever the reason. That seems like a more >> r