Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove -w (--ignore-all-space) option from pg_regress's diff

2009-11-23 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan writes: Tom Lane wrote: I'm thinking that the most appropriate fix is to have pg_regress continue to use -w, but only on Windows. Well, the filter could be as simple as something like this in the Makefile for the mingw case:

Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove -w (--ignore-all-space) option from pg_regress's diff

2009-11-23 Thread Tom Lane
Andrew Dunstan writes: > Tom Lane wrote: >> I'm thinking that the most appropriate fix is to have pg_regress >> continue to use -w, but only on Windows. > Well, the filter could be as simple as something like this in the > Makefile for the mingw case: > perl -spi.bak -e 's/(? rm expecte

Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove -w (--ignore-all-space) option from pg_regress's diff

2009-11-23 Thread Andrew Dunstan
Tom Lane wrote: Magnus Hagander writes: On Mon, Nov 23, 2009 at 06:58, Andrew Dunstan wrote: They might not be using the same CVS programs, though. It appears that Windows CVS (which, for example, red_bat uses) translates line endings to CRLF, which is why it passed the regression t

Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove -w (--ignore-all-space) option from pg_regress's diff

2009-11-23 Thread Magnus Hagander
On Mon, Nov 23, 2009 at 15:23, Tom Lane wrote: > Magnus Hagander writes: >> On Mon, Nov 23, 2009 at 06:58, Andrew Dunstan wrote: >>> They might not be using the same CVS programs, though. It appears that >>> Windows CVS (which, for example, red_bat uses) translates line endings to >>> CRLF, whic

Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove -w (--ignore-all-space) option from pg_regress's diff

2009-11-23 Thread Tom Lane
Magnus Hagander writes: > On Mon, Nov 23, 2009 at 06:58, Andrew Dunstan wrote: >> They might not be using the same CVS programs, though. It appears that >> Windows CVS (which, for example, red_bat uses) translates line endings to >> CRLF, which is why it passed the regression tests, but MinGW CVS

Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove -w (--ignore-all-space) option from pg_regress's diff

2009-11-23 Thread Magnus Hagander
On Mon, Nov 23, 2009 at 06:58, Andrew Dunstan wrote: > > > Tom Lane wrote: >> >> Andrew Dunstan writes: >> >>> >>> Tom Lane wrote: >>> Remove -w (--ignore-all-space) option from pg_regress's diff calls. >> >> >>> >>> Looks like this has broken on Windows due to different line endin

[HACKERS] Re: [COMMITTERS] pgsql: Remove -w (--ignore-all-space) option from pg_regress's diff

2009-11-22 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan writes: Tom Lane wrote: Remove -w (--ignore-all-space) option from pg_regress's diff calls. Looks like this has broken on Windows due to different line endings, which -w hid from us. Yeah. I was waiting for brown_bat to report in be